Test aborting an inactive Background Fetch registration

content/browser/background_fetch/background_fetch_service_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "content/browser/background_fetch/background_fetch_context.h"
@@ skipping 329 matching lines @@
   // Now try to get the created registration, which is expected to fail.
   ASSERT_NO_FATAL_FAILURE(
       GetRegistration(registration_id, &second_error, &second_registration));
   ASSERT_EQ(second_error, blink::mojom::BackgroundFetchError::INVALID_TAG);
 }
 
 TEST_F(BackgroundFetchServiceTest, AbortInvalidArguments) {
   // This test verifies that the Abort() function will kill the renderer and
   // return INVALID_ARGUMENT when invalid data is send over the Mojo channel.
 
-  BackgroundFetchOptions options;
+  BackgroundFetchRegistrationId registration_id(
+      42 /* service_worker_registration_id */, origin(), "" /* tag */);
 
-  // The `tag` must be a non-empty string.
-  {
-    BackgroundFetchRegistrationId registration_id(
-        42 /* service_worker_registration_id */, origin(), "" /* tag */);
+  blink::mojom::BackgroundFetchError error;
 
-    blink::mojom::BackgroundFetchError error;
+  ASSERT_NO_FATAL_FAILURE(Abort(registration_id, &error));
+  ASSERT_EQ(error, blink::mojom::BackgroundFetchError::INVALID_ARGUMENT);
+}
 
-    ASSERT_NO_FATAL_FAILURE(Abort(registration_id, &error));
-    ASSERT_EQ(error, blink::mojom::BackgroundFetchError::INVALID_ARGUMENT);
-  }
+TEST_F(BackgroundFetchServiceTest, AbortInvalidTag) {
+  // This test verifies that aborting a Background Fetch registration with a
+  // tag that does not correspond to an active fetch kindly tells us so.
+
+  BackgroundFetchRegistrationId registration_id;
+  ASSERT_TRUE(CreateRegistrationId(kExampleTag, &registration_id));
+
+  // Deliberate do *not* create a fetch for the |registration_id|.
+
+  blink::mojom::BackgroundFetchError error;
+
+  ASSERT_NO_FATAL_FAILURE(Abort(registration_id, &error));
+  ASSERT_EQ(error, blink::mojom::BackgroundFetchError::INVALID_TAG);
 }
 
 TEST_F(BackgroundFetchServiceTest, GetTags) {
   // This test verifies that the list of active tags can be retrieved from the
   // service for a given Service Worker, as extracted from a registration.
 
   BackgroundFetchRegistrationId registration_id;
   ASSERT_TRUE(CreateRegistrationId(kExampleTag, &registration_id));
 
   BackgroundFetchRegistrationId second_registration_id;
@@ skipping 63 matching lines @@
     const bool has_alternative_tag =
         tags[0] == kAlternativeTag || tags[1] == kAlternativeTag;
 
     EXPECT_TRUE(has_example_tag);
     EXPECT_TRUE(has_alternative_tag);
   }
 }
 
 }  // namespace
 }  // namespace content