Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/browser_side_navigation_browsertest.cc

Issue 2781383002: Followup comments from r460581. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.h » ('j') | third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_side_navigation_browsertest.cc
diff --git a/content/browser/browser_side_navigation_browsertest.cc b/content/browser/browser_side_navigation_browsertest.cc
index 05e0195f342be47e406ad838d45f63ca447a41a8..c7b3109808b3c3b87eeb41f90f80118da35163c0 100644
--- a/content/browser/browser_side_navigation_browsertest.cc
+++ b/content/browser/browser_side_navigation_browsertest.cc
@@ -282,9 +282,8 @@ IN_PROC_BROWSER_TEST_F(BrowserSideNavigationBrowserTest,
content::WindowedNotificationObserver close_observer(
content::NOTIFICATION_WEB_CONTENTS_DESTROYED,
content::Source<content::WebContents>(shell()->web_contents()));
- GURL url(
- "data:text/html,<html><script>window.onbeforeunload=function(e)"
- "{}</script></html>");
+ GURL url =
+ embedded_test_server()->GetURL("/page_with_empty_beforeunload.html");
NavigateToURL(shell(), url);
shell()->LoadURL(GURL("chrome://resources/css/tabs.css"));
shell()->web_contents()->DispatchBeforeUnload();
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.h » ('j') | third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698