Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2783183002: Stream DoubleLiteral (Closed)

Created:
3 years, 8 months ago by jensj
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -22 lines) Patch
M runtime/vm/kernel_binary_flowgraph.h View 3 chunks +48 lines, -2 lines 1 comment Download
M runtime/vm/kernel_binary_flowgraph.cc View 8 chunks +156 lines, -19 lines 4 comments Download
M runtime/vm/kernel_to_il.h View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 2 chunks +9 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2781313003 Patch 20001

Dependent Patchsets:

Issue 2786073002 Patch 1

Messages

Total messages: 5 (2 generated)
jensj
3 years, 8 months ago (2017-03-30 12:06:17 UTC) #2
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/2783183002/diff/1/runtime/vm/kernel_binary_flowgraph.cc File runtime/vm/kernel_binary_flowgraph.cc (right): https://codereview.chromium.org/2783183002/diff/1/runtime/vm/kernel_binary_flowgraph.cc#newcode18 runtime/vm/kernel_binary_flowgraph.cc:18: TranslationHelper* h, h ==> helper https://codereview.chromium.org/2783183002/diff/1/runtime/vm/kernel_binary_flowgraph.cc#newcode24 runtime/vm/kernel_binary_flowgraph.cc:24: // ...
3 years, 8 months ago (2017-03-31 12:23:41 UTC) #3
jensj
3 years, 8 months ago (2017-04-03 10:18:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
819ce4241c4b662c3c31c37de18271b6a9c05335 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698