DevTools: Adopt nbsp as unit & thousands separator for broader font support

DevTools: Adopt nbsp as unit & thousands separator for broader font support

Helvetica Neue, our current display font on mac, lacks support for   -
rendering it without any space at all. The non-breaking space has 
approximately the same width and much wider font support.

BUG=697599
Review-Url: https://codereview.chromium.org/2781193002
Cr-Commit-Position: refs/heads/master@{#461003}
Committed: https://chromium.googlesource.com/chromium/src/+/6d5f76795cd8992a4249408bca4f1efc48e79832

[paulirish, 2017-03-29 22:52:41]

paulirish@chromium.org changed reviewers:
+ lushnikov@chromium.org, pfeldman@chromium.org

[lushnikov, 2017-03-29 22:54:39]

lgtm

[paulirish, 2017-03-29 23:04:01]

The CQ bit was checked by paulirish@chromium.org

[commit-bot: I haz the power, 2017-03-29 23:05:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2017-03-29 23:23:14]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2017-03-29 23:23:14]

not lgtm. en space is too large

[alph, 2017-03-29 23:23:20]

The CQ bit was unchecked by alph@chromium.org

[alph, 2017-03-29 23:55:29]

Consider using \xa0 instead

[paulirish, 2017-03-31 01:03:52]

Description was changed from

==========
DevTools: Use en space as thousands separator for wider font support

BUG=697599
==========

to

==========
DevTools: Adopt nbsp as unit & thousands separator for broader font support

Helvetica Neue, our current display font on mac, lacks support for  ,
rendering it without any space at all. The non-breaking space has 
approximately the same width and much wider font support.

BUG=697599
==========

[paulirish, 2017-03-31 01:04:01]

alph, ptal?

[paulirish, 2017-03-31 01:04:11]

The CQ bit was checked by paulirish@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 01:05:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-03-31 01:19:30]

lgtm

[alph, 2017-03-31 01:19:59]

lgtm. thanks!

[paulirish, 2017-03-31 01:21:05]

Description was changed from

==========
DevTools: Adopt nbsp as unit & thousands separator for broader font support

Helvetica Neue, our current display font on mac, lacks support for  ,
rendering it without any space at all. The non-breaking space has 
approximately the same width and much wider font support.

BUG=697599
==========

to

==========
DevTools: Adopt nbsp as unit & thousands separator for broader font support

Helvetica Neue, our current display font on mac, lacks support for   -
rendering it without any space at all. The non-breaking space has 
approximately the same width and much wider font support.

BUG=697599
==========

[paulirish, 2017-03-31 01:21:28]

The CQ bit was unchecked by paulirish@chromium.org

[paulirish, 2017-03-31 01:21:30]

The CQ bit was checked by paulirish@chromium.org

[paulirish, 2017-03-31 01:21:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2781193002/#ps60001
(title: "update all uses of thinsp. rebaseline tests.")

[commit-bot: I haz the power, 2017-03-31 01:22:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 02:38:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490923290637760,
"parent_rev": "bd8ddbe23babcdf02ecd0fc9efe85023e92dff4d", "commit_rev":
"6d5f76795cd8992a4249408bca4f1efc48e79832"}

[commit-bot: I haz the power, 2017-03-31 02:39:11]

Description was changed from

==========
DevTools: Adopt nbsp as unit & thousands separator for broader font support

Helvetica Neue, our current display font on mac, lacks support for   -
rendering it without any space at all. The non-breaking space has 
approximately the same width and much wider font support.

BUG=697599
==========

to

==========
DevTools: Adopt nbsp as unit & thousands separator for broader font support

Helvetica Neue, our current display font on mac, lacks support for   -
rendering it without any space at all. The non-breaking space has 
approximately the same width and much wider font support.

BUG=697599

Review-Url: https://codereview.chromium.org/2781193002
Cr-Commit-Position: refs/heads/master@{#461003}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d5f76795cd8992a4249408bca4f...
==========

[commit-bot: I haz the power, 2017-03-31 02:39:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6d5f76795cd8992a4249408bca4f...