third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js - Issue 2781193002: DevTools: Adopt nbsp as unit & thousands separator for broader font support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2781193002: DevTools: Adopt nbsp as unit & thousands separator for broader font support (Closed)

Patch Set: update all uses of thinsp. rebaseline tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

index 1b663eed2c529d74f912dc040fcb2b818914f489..a7915cddb9690b574e6cef926c843a5f1bff9ca9 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

@@ -569,11 +569,11 @@ Timeline.TimelineTreeView.GridNode = class extends DataGrid.SortableDataGridNode

var cell = this.createTD(columnId);

cell.className = 'numeric-column';

var textDiv = cell.createChild('div');

- textDiv.createChild('span').textContent = Common.UIString('%.1f\u2009ms', value);

+ textDiv.createChild('span').textContent = Common.UIString('%.1f\xa0ms', value);

if (showPercents && this._treeView._exposePercentages()) {

textDiv.createChild('span', 'percent-column').textContent =

- Common.UIString('%.1f\u2009%%', value / this._grandTotalTime * 100);

+ Common.UIString('%.1f\xa0%%', value / this._grandTotalTime * 100);

}

if (maxTime) {

textDiv.classList.add('background-percent-bar');