Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2781163002: Modify V8 histograms by adding asm/wasm suffices. (Closed)

Created:
3 years, 8 months ago by kschimpf
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify V8 histograms by adding asm/wasm suffices. Do final change to chrome histogram flags so that V8 UMA will start collecting separate statistics for asm.js and WASM modules. This is being done because asm.js and WASM modules have different semantics and size expectations, making it very hard to tell what are asm.js issues and what are WASM module issues. To fix this, adding suffixes "asm" and "wasm" to current histograms. Code for V8 has already been modified to collect separately, except for histogram table names. This fianl fix for histogram table names can be found in: CL https://codereview.chromium.org/2781073003 BUG=chromium:704922 R=isherman@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2781163002 Cr-Commit-Position: refs/heads/master@{#460801} Committed: https://chromium.googlesource.com/chromium/src/+/76f352d199b02329412d95dca14fb8985968c62a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kschimpf
Please review. Thanks.
3 years, 8 months ago (2017-03-29 21:30:26 UTC) #5
bradnelson
lgtm But need OWNERS from Iyla
3 years, 8 months ago (2017-03-29 21:34:59 UTC) #6
Ilya Sherman
LGTM
3 years, 8 months ago (2017-03-29 21:59:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781163002/1
3 years, 8 months ago (2017-03-30 16:55:02 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 17:03:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76f352d199b02329412d95dca14f...

Powered by Google App Engine
This is Rietveld 408576698