Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2781073003:
Change Chrome name for histograms to show asm/wasm targets. (Closed)
DescriptionChange Chrome name for histograms to show asm/wasm targets.
Do final change to Chrome flags so that UMA will start collecting
separate statistics, using a "histogram_suffixes" format.
Corresponding changes to chromium are in:
CL https://codereview.chromium.org/2781163002
BUG=chromium:704922
R=bradnelson@chromium.org,bbudge@chromium.org
Review-Url: https://codereview.chromium.org/2781073003
Cr-Commit-Position: refs/heads/master@{#44255}
Committed: https://chromium.googlesource.com/v8/v8/+/85d731e930c16b048bef14af941d1010c04b0759
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix typo #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Change Chrome name for histograms to show asm/wasm targets. Do final change to Chrome flags so that UMA will start collecting separate statistics, using a "histogram_suffixes" format. BUG=chromium:704922 ========== to ========== Change Chrome name for histograms to show asm/wasm targets. Do final change to Chrome flags so that UMA will start collecting separate statistics, using a "histogram_suffixes" format. Corresponding changes to chromium are in: CL https://codereview.chromium.org/2781163002 BUG=chromium:704922 ==========
kschimpf@chromium.org changed reviewers: + bbudge@chromium.org, bradnelson@chromium.org
Description was changed from ========== Change Chrome name for histograms to show asm/wasm targets. Do final change to Chrome flags so that UMA will start collecting separate statistics, using a "histogram_suffixes" format. Corresponding changes to chromium are in: CL https://codereview.chromium.org/2781163002 BUG=chromium:704922 ========== to ========== Change Chrome name for histograms to show asm/wasm targets. Do final change to Chrome flags so that UMA will start collecting separate statistics, using a "histogram_suffixes" format. Corresponding changes to chromium are in: CL https://codereview.chromium.org/2781163002 BUG=chromium:704922 R=bradnelson@chromium.org,bbudge@chromium.org ==========
Please review. Thanks.
https://codereview.chromium.org/2781073003/diff/1/src/counters.h File src/counters.h (right): https://codereview.chromium.org/2781073003/diff/1/src/counters.h#newcode1023 src/counters.h:1023: V8.WasmDecodeModulePeakMemoryBytes.asm) \ s/asm/wasm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm sans the problem Bill caught.
The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2781073003/diff/1/src/counters.h File src/counters.h (right): https://codereview.chromium.org/2781073003/diff/1/src/counters.h#newcode1023 src/counters.h:1023: V8.WasmDecodeModulePeakMemoryBytes.asm) \ On 2017/03/29 21:31:49, bbudge wrote: > s/asm/wasm Done.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kschimpf@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2781073003/#ps20001 (title: "Fix typo")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490827037802380,
"parent_rev": "29dc4898c84bf5b8be284df069b01ecb95dd2f8e", "commit_rev":
"85d731e930c16b048bef14af941d1010c04b0759"}
Message was sent while issue was closed.
Description was changed from ========== Change Chrome name for histograms to show asm/wasm targets. Do final change to Chrome flags so that UMA will start collecting separate statistics, using a "histogram_suffixes" format. Corresponding changes to chromium are in: CL https://codereview.chromium.org/2781163002 BUG=chromium:704922 R=bradnelson@chromium.org,bbudge@chromium.org ========== to ========== Change Chrome name for histograms to show asm/wasm targets. Do final change to Chrome flags so that UMA will start collecting separate statistics, using a "histogram_suffixes" format. Corresponding changes to chromium are in: CL https://codereview.chromium.org/2781163002 BUG=chromium:704922 R=bradnelson@chromium.org,bbudge@chromium.org Review-Url: https://codereview.chromium.org/2781073003 Cr-Commit-Position: refs/heads/master@{#44255} Committed: https://chromium.googlesource.com/v8/v8/+/85d731e930c16b048bef14af941d1010c04... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/85d731e930c16b048bef14af941d1010c04... |
