Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 278113002: Remove PlatformFile from fileapi::AsyncFileUtil (Closed)

Created:
6 years, 7 months ago by rvargas (doing something else)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), nkostylev+watch_chromium.org, tzik, tfarina, Greg Billock, nhiroki, tommycli, darin-cc_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove PlatformFile from fileapi::AsyncFileUtil BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270791

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -180 lines) Patch
M chrome/browser/chromeos/drive/fileapi/async_file_util.cc View 6 chunks +22 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/fileapi_worker.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc View 5 chunks +23 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/fileapi_worker_unittest.cc View 7 chunks +22 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc View 1 7 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/local_discovery/storage/privet_filesystem_async_util.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/device_media_async_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 4 chunks +6 lines, -20 lines 0 comments Download
M webkit/browser/fileapi/async_file_util.h View 15 chunks +33 lines, -35 lines 0 comments Download
M webkit/browser/fileapi/async_file_util_adapter.cc View 1 chunk +1 line, -13 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_impl.cc View 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rvargas (doing something else)
kinuko -> webkit satorux -> chromeos thesting -> chrome (-chromeos) PTAL
6 years, 7 months ago (2014-05-15 01:52:14 UTC) #1
Lei Zhang
lgtm, and I'll try not to sting anyone.
6 years, 7 months ago (2014-05-15 01:57:01 UTC) #2
rvargas (doing something else)
On 2014/05/15 01:57:01, Lei Zhang wrote: > lgtm, and I'll try not to sting anyone. ...
6 years, 7 months ago (2014-05-15 02:15:27 UTC) #3
satorux1
I'd defer to kinaba@ for c/b/chromeos
6 years, 7 months ago (2014-05-15 03:14:44 UTC) #4
kinaba
lgtm
6 years, 7 months ago (2014-05-15 08:03:15 UTC) #5
kinuko
webkit/ lgtm
6 years, 7 months ago (2014-05-15 12:31:03 UTC) #6
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 7 months ago (2014-05-15 18:03:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/278113002/100001
6 years, 7 months ago (2014-05-15 18:05:35 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 19:50:39 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 20:03:25 UTC) #10
Message was sent while issue was closed.
Change committed as 270791

Powered by Google App Engine
This is Rietveld 408576698