Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: webkit/browser/fileapi/async_file_util_adapter.cc

Issue 278113002: Remove PlatformFile from fileapi::AsyncFileUtil (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/browser/fileapi/async_file_util.h ('k') | webkit/browser/fileapi/file_system_operation_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/browser/fileapi/async_file_util_adapter.cc
diff --git a/webkit/browser/fileapi/async_file_util_adapter.cc b/webkit/browser/fileapi/async_file_util_adapter.cc
index 20463d15a7a4a888e8809857bafd0425238268a3..5a99effbd6f1735328d9320f00bb034d68aaaf7d 100644
--- a/webkit/browser/fileapi/async_file_util_adapter.cc
+++ b/webkit/browser/fileapi/async_file_util_adapter.cc
@@ -136,19 +136,7 @@ void RunCreateOrOpenCallback(
FileSystemOperationContext* context,
const AsyncFileUtil::CreateOrOpenCallback& callback,
base::File file) {
- // TODO(rvargas): Remove PlatformFile from AsyncFileUtil.
- base::File::Error error;
- base::PlatformFile platform_file;
- if (file.IsValid()) {
- error = base::File::FILE_OK;
- platform_file = file.TakePlatformFile();
- } else {
- error = file.error_details();
- platform_file = base::kInvalidPlatformFileValue;
- }
-
- callback.Run(error, base::PassPlatformFile(&platform_file), base::Closure());
- base::File closer(platform_file);
+ callback.Run(file.Pass(), base::Closure());
}
} // namespace
« no previous file with comments | « webkit/browser/fileapi/async_file_util.h ('k') | webkit/browser/fileapi/file_system_operation_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698