chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc - Issue 278113002: Remove PlatformFile from fileapi::AsyncFileUtil

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc

Issue 278113002: Remove PlatformFile from fileapi::AsyncFileUtil (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/device_media_async_file_util.h ('k') | chrome/browser/media_galleries/fileapi/native_media_file_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc

diff --git a/chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc b/chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc

index 18f3018cfc29eab86ee1e56364411c36c02b439b..fad8c618fb8e050a23efcf3a7fcbdcbd401627fa 100644

--- a/chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc

+++ b/chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc

@@ -89,10 +89,7 @@ void DeviceMediaAsyncFileUtil::CreateOrOpen(

if (file_flags & ~(base::File::FLAG_OPEN |

base::File::FLAG_READ |

base::File::FLAG_WRITE_ATTRIBUTES)) {

- base::PlatformFile invalid_file(base::kInvalidPlatformFileValue);

- callback.Run(base::File::FILE_ERROR_SECURITY,

- base::PassPlatformFile(&invalid_file),

- base::Closure());

+ callback.Run(base::File(base::File::FILE_ERROR_SECURITY), base::Closure());

return;

}

CreateSnapshotFile(