Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2780993003: Remove redundant WebLocalFrame* parameter from didCreateDataSource (Closed)
Patch Set: Changed to just dcheck change Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 3445 matching lines...) Expand 10 before | Expand all | Expand 10 after
3456 internal_data->set_searchable_form_url(web_searchable_form_data.Url()); 3456 internal_data->set_searchable_form_url(web_searchable_form_data.Url());
3457 internal_data->set_searchable_form_encoding( 3457 internal_data->set_searchable_form_encoding(
3458 web_searchable_form_data.Encoding().Utf8()); 3458 web_searchable_form_data.Encoding().Utf8());
3459 3459
3460 for (auto& observer : observers_) 3460 for (auto& observer : observers_)
3461 observer.WillSubmitForm(form); 3461 observer.WillSubmitForm(form);
3462 } 3462 }
3463 3463
3464 void RenderFrameImpl::DidCreateDataSource(blink::WebLocalFrame* frame, 3464 void RenderFrameImpl::DidCreateDataSource(blink::WebLocalFrame* frame,
3465 blink::WebDataSource* datasource) { 3465 blink::WebDataSource* datasource) {
3466 DCHECK(!frame_ || frame_ == frame); 3466 DCHECK(frame_ == frame);
3467 3467
3468 bool content_initiated = !pending_navigation_params_.get(); 3468 bool content_initiated = !pending_navigation_params_.get();
3469 3469
3470 // Make sure any previous redirect URLs end up in our new data source. 3470 // Make sure any previous redirect URLs end up in our new data source.
3471 if (pending_navigation_params_.get() && !IsBrowserSideNavigationEnabled()) { 3471 if (pending_navigation_params_.get() && !IsBrowserSideNavigationEnabled()) {
3472 for (const auto& i : 3472 for (const auto& i :
3473 pending_navigation_params_->request_params.redirects) { 3473 pending_navigation_params_->request_params.redirects) {
3474 datasource->AppendRedirect(i); 3474 datasource->AppendRedirect(i);
3475 } 3475 }
3476 } 3476 }
(...skipping 3588 matching lines...) Expand 10 before | Expand all | Expand 10 after
7065 policy(info.default_policy), 7065 policy(info.default_policy),
7066 replaces_current_history_item(info.replaces_current_history_item), 7066 replaces_current_history_item(info.replaces_current_history_item),
7067 history_navigation_in_new_child_frame( 7067 history_navigation_in_new_child_frame(
7068 info.is_history_navigation_in_new_child_frame), 7068 info.is_history_navigation_in_new_child_frame),
7069 client_redirect(info.is_client_redirect), 7069 client_redirect(info.is_client_redirect),
7070 cache_disabled(info.is_cache_disabled), 7070 cache_disabled(info.is_cache_disabled),
7071 form(info.form), 7071 form(info.form),
7072 source_location(info.source_location) {} 7072 source_location(info.source_location) {}
7073 7073
7074 } // namespace content 7074 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698