Remove redundant WebLocalFrame* parameter from didCreateDataSource

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 3366 matching lines @@
     // Save these to be processed when the ensuing navigation is committed.
     WebSearchableFormData web_searchable_form_data(form);
     internal_data->set_searchable_form_url(web_searchable_form_data.url());
     internal_data->set_searchable_form_encoding(
         web_searchable_form_data.encoding().utf8());
 
   for (auto& observer : observers_)
     observer.WillSubmitForm(form);
 }
 
-void RenderFrameImpl::didCreateDataSource(blink::WebLocalFrame* frame,
-                                          blink::WebDataSource* datasource) {
-  DCHECK(!frame_ || frame_ == frame);

[jochen (gone - plz use gerrit), 2017/03/30 11:43:43]

this doesn't look like it's good enough to proof redundancy (and I think the
crashes you get on the bots are due to this)

-
+void RenderFrameImpl::didCreateDataSource(blink::WebDataSource* datasource) {
   bool content_initiated = !pending_navigation_params_.get();
 
   // Make sure any previous redirect URLs end up in our new data source.
   if (pending_navigation_params_.get() && !IsBrowserSideNavigationEnabled()) {
     for (const auto& i :
          pending_navigation_params_->request_params.redirects) {
       datasource->appendRedirect(i);
     }
   }
 
@@ skipping 71 matching lines @@
   }
 
   // Create the serviceworker's per-document network observing object if it
   // does not exist (When navigation happens within a page, the provider already
   // exists).
   if (datasource->getServiceWorkerNetworkProvider())
     return;
 
   datasource->setServiceWorkerNetworkProvider(
       ServiceWorkerNetworkProvider::CreateForNavigation(
-          routing_id_, navigation_state->request_params(), frame,
+          routing_id_, navigation_state->request_params(), frame_,
           content_initiated));
 }
 
 void RenderFrameImpl::didStartProvisionalLoad(blink::WebDataSource* data_source,
                                               blink::WebURLRequest& request) {
   // In fast/loader/stop-provisional-loads.html, we abort the load before this
   // callback is invoked.
   if (!data_source)
     return;
 
@@ skipping 3476 matching lines @@
       policy(info.defaultPolicy),
       replaces_current_history_item(info.replacesCurrentHistoryItem),
       history_navigation_in_new_child_frame(
           info.isHistoryNavigationInNewChildFrame),
       client_redirect(info.isClientRedirect),
       cache_disabled(info.isCacheDisabled),
       form(info.form),
       source_location(info.sourceLocation) {}
 
 }  // namespace content