Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2780863003: Fix base::nix::GetDesktopEnvironment for newer versions of Unity (Closed)

Created:
3 years, 8 months ago by Tom (Use chromium acct)
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix base::nix::GetDesktopEnvironment for newer versions of Unity This CL fixes some desktop integration issues on Ubuntu 17.04, where XDG_CURRENT_DESKTOP has changed from 'Unity' to 'Unity:Unity7' (or 'Unity:Unity8' if you're of the Mir persuasion). BUG=706317 R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2780863003 Cr-Commit-Position: refs/heads/master@{#460492} Committed: https://chromium.googlesource.com/chromium/src/+/9ac9895f221d2ca88e4537bd9304ad679c0e5771

Patch Set 1 #

Patch Set 2 : add new tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M base/nix/xdg_util.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/nix/xdg_util_unittest.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Tom (Use chromium acct)
lei ptal
3 years, 8 months ago (2017-03-29 17:40:22 UTC) #2
Lei Zhang
lgtm Update xdg_util_unittest.cc as well?
3 years, 8 months ago (2017-03-29 18:07:29 UTC) #4
Tom (Use chromium acct)
On 2017/03/29 18:07:29, Lei Zhang wrote: > Update xdg_util_unittest.cc as well? Done
3 years, 8 months ago (2017-03-29 18:10:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780863003/20001
3 years, 8 months ago (2017-03-29 18:11:37 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:35:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9ac9895f221d2ca88e4537bd9304...

Powered by Google App Engine
This is Rietveld 408576698