Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: base/nix/xdg_util_unittest.cc

Issue 2780863003: Fix base::nix::GetDesktopEnvironment for newer versions of Unity (Closed)
Patch Set: add new tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/nix/xdg_util.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/nix/xdg_util.h" 5 #include "base/nix/xdg_util.h"
6 6
7 #include "base/environment.h" 7 #include "base/environment.h"
8 #include "testing/gmock/include/gmock/gmock.h" 8 #include "testing/gmock/include/gmock/gmock.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 17 matching lines...) Expand all
28 // Needs to be const char* to make gmock happy. 28 // Needs to be const char* to make gmock happy.
29 const char* const kDesktopGnome = "gnome"; 29 const char* const kDesktopGnome = "gnome";
30 const char* const kDesktopGnomeFallback = "gnome-fallback"; 30 const char* const kDesktopGnomeFallback = "gnome-fallback";
31 const char* const kDesktopMATE = "mate"; 31 const char* const kDesktopMATE = "mate";
32 const char* const kDesktopKDE4 = "kde4"; 32 const char* const kDesktopKDE4 = "kde4";
33 const char* const kDesktopKDE = "kde"; 33 const char* const kDesktopKDE = "kde";
34 const char* const kDesktopXFCE = "xfce"; 34 const char* const kDesktopXFCE = "xfce";
35 const char* const kXdgDesktopGNOME = "GNOME"; 35 const char* const kXdgDesktopGNOME = "GNOME";
36 const char* const kXdgDesktopKDE = "KDE"; 36 const char* const kXdgDesktopKDE = "KDE";
37 const char* const kXdgDesktopUnity = "Unity"; 37 const char* const kXdgDesktopUnity = "Unity";
38 const char* const kXdgDesktopUnity7 = "Unity:Unity7";
39 const char* const kXdgDesktopUnity8 = "Unity:Unity8";
38 const char* const kKDESessionKDE5 = "5"; 40 const char* const kKDESessionKDE5 = "5";
39 41
40 const char kDesktopSession[] = "DESKTOP_SESSION"; 42 const char kDesktopSession[] = "DESKTOP_SESSION";
41 const char kKDESession[] = "KDE_SESSION_VERSION"; 43 const char kKDESession[] = "KDE_SESSION_VERSION";
42 const char kXdgDesktop[] = "XDG_CURRENT_DESKTOP"; 44 const char kXdgDesktop[] = "XDG_CURRENT_DESKTOP";
43 45
44 } // namespace 46 } // namespace
45 47
46 TEST(XDGUtilTest, GetDesktopEnvironmentGnome) { 48 TEST(XDGUtilTest, GetDesktopEnvironmentGnome) {
47 MockEnvironment getter; 49 MockEnvironment getter;
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 133
132 TEST(XDGUtilTest, GetXdgDesktopUnity) { 134 TEST(XDGUtilTest, GetXdgDesktopUnity) {
133 MockEnvironment getter; 135 MockEnvironment getter;
134 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 136 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
135 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _)) 137 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _))
136 .WillOnce(DoAll(SetArgumentPointee<1>(kXdgDesktopUnity), Return(true))); 138 .WillOnce(DoAll(SetArgumentPointee<1>(kXdgDesktopUnity), Return(true)));
137 139
138 EXPECT_EQ(DESKTOP_ENVIRONMENT_UNITY, GetDesktopEnvironment(&getter)); 140 EXPECT_EQ(DESKTOP_ENVIRONMENT_UNITY, GetDesktopEnvironment(&getter));
139 } 141 }
140 142
143 TEST(XDGUtilTest, GetXdgDesktopUnity7) {
144 MockEnvironment getter;
145 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
146 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _))
147 .WillOnce(DoAll(SetArgumentPointee<1>(kXdgDesktopUnity7), Return(true)));
148
149 EXPECT_EQ(DESKTOP_ENVIRONMENT_UNITY, GetDesktopEnvironment(&getter));
150 }
151
152 TEST(XDGUtilTest, GetXdgDesktopUnity8) {
153 MockEnvironment getter;
154 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
155 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _))
156 .WillOnce(DoAll(SetArgumentPointee<1>(kXdgDesktopUnity8), Return(true)));
157
158 EXPECT_EQ(DESKTOP_ENVIRONMENT_UNITY, GetDesktopEnvironment(&getter));
159 }
160
141 } // namespace nix 161 } // namespace nix
142 } // namespace base 162 } // namespace base
OLDNEW
« no previous file with comments | « base/nix/xdg_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698