Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Issue 2780843002: Split image decode cache limits into "working set" vs "cache" limits (Closed)

Created:
3 years, 8 months ago by ericrk
Modified:
3 years, 8 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Split image decode cache limits into "working set" vs "cache" limits Working set limit impacts how many images we will keep locked before going to at-raster. This is different from the cache limit, which impacts how many images we will keep around once unlocked. SW Image Decode Cache doesn't use cache limit, just working set, as it keeps all not-in-use images unlocked and effectively "free". BUG=706470 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2780843002 Cr-Commit-Position: refs/heads/master@{#460461} Committed: https://chromium.googlesource.com/chromium/src/+/8e3f651d6b76a33f580ea9811b64168610d3ebd4

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 6

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -60 lines) Patch
M cc/raster/raster_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_tile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/gpu_image_decode_cache.h View 1 4 chunks +11 lines, -7 lines 0 comments Download
M cc/tiles/gpu_image_decode_cache.cc View 1 2 8 chunks +31 lines, -14 lines 0 comments Download
M cc/tiles/gpu_image_decode_cache_unittest.cc View 8 chunks +187 lines, -27 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 33 (24 generated)
ericrk
3 years, 8 months ago (2017-03-28 18:24:11 UTC) #3
vmpstr
lgtm https://codereview.chromium.org/2780843002/diff/20001/cc/tiles/gpu_image_decode_cache.cc File cc/tiles/gpu_image_decode_cache.cc (right): https://codereview.chromium.org/2780843002/diff/20001/cc/tiles/gpu_image_decode_cache.cc#newcode933 cc/tiles/gpu_image_decode_cache.cc:933: // Ensures that we can fit a new ...
3 years, 8 months ago (2017-03-28 18:41:31 UTC) #6
ericrk
+aelias@ for render_widget_compositor.cc changes. https://codereview.chromium.org/2780843002/diff/20001/cc/tiles/gpu_image_decode_cache.cc File cc/tiles/gpu_image_decode_cache.cc (right): https://codereview.chromium.org/2780843002/diff/20001/cc/tiles/gpu_image_decode_cache.cc#newcode933 cc/tiles/gpu_image_decode_cache.cc:933: // Ensures that we can ...
3 years, 8 months ago (2017-03-28 20:10:11 UTC) #10
aelias_OOO_until_Jul13
lgtm
3 years, 8 months ago (2017-03-28 20:55:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780843002/40001
3 years, 8 months ago (2017-03-28 22:15:40 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/393479)
3 years, 8 months ago (2017-03-29 01:56:02 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780843002/40001
3 years, 8 months ago (2017-03-29 17:29:40 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780843002/40001
3 years, 8 months ago (2017-03-29 17:38:12 UTC) #30
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 18:24:08 UTC) #33
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8e3f651d6b76a33f580ea9811b64...

Powered by Google App Engine
This is Rietveld 408576698