Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 2780723004: Revert of [Chromedriver] Add testcase for testing alert on new window. (Closed)

Created:
3 years, 8 months ago by samuong
Modified:
3 years, 8 months ago
Reviewers:
gmanikpure
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromedriver] Add testcase for testing alert on new window. (patchset #3 id:40001 of https://codereview.chromium.org/1882603003/ ) Reason for revert: This seems to be causing waterfall failures (I think the filter should be added to _NEGATIVE_FILTER, not the Android-specific filter?) Original issue's description: > [Chromedriver] Add testcase for testing alert on new window. > > And disable it by default until the issue is fixed. > > BUG=chromedriver:833 > > Review-Url: https://codereview.chromium.org/1882603003 > Cr-Commit-Position: refs/heads/master@{#459971} > Committed: https://chromium.googlesource.com/chromium/src/+/1512539632abf713b55f5a16fe7b709fb1f4a57d TBR=gmanikpure@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromedriver:833 Review-Url: https://codereview.chromium.org/2780723004 Cr-Commit-Position: refs/heads/master@{#460245} Committed: https://chromium.googlesource.com/chromium/src/+/5f7733dd5fc1bcc2bc979c83cea73f351695083d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 2 chunks +0 lines, -13 lines 0 comments Download
D chrome/test/data/chromedriver/alert_onload.html View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
samuong
Created Revert of [Chromedriver] Add testcase for testing alert on new window.
3 years, 8 months ago (2017-03-29 00:01:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780723004/1
3 years, 8 months ago (2017-03-29 00:01:58 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 00:06:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f7733dd5fc1bcc2bc979c83cea7...

Powered by Google App Engine
This is Rietveld 408576698