Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5756)

Unified Diff: chrome/test/chromedriver/test/run_py_tests.py

Issue 2780723004: Revert of [Chromedriver] Add testcase for testing alert on new window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/chromedriver/alert_onload.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test/run_py_tests.py
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index 40c1b81a38ebb3e205df3b94c2b1d58e9b34f75b..6d97e183e45c8c10c4f9d6632544b9017a26bc93 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -213,7 +213,6 @@
'testHistoryNavigationWithPageLoadTimeout',
# Webview shell doesn't support Alerts.
'ChromeDriverTest.testAlert',
- 'ChromeDriverTest.testAlertOnNewWindow',
'ChromeDesiredCapabilityTest.testUnexpectedAlertBehaviour',
]
)
@@ -788,18 +787,6 @@
self.assertFalse(self._driver.IsAlertOpen())
self.assertEquals(False,
self._driver.ExecuteScript('return window.confirmed'))
-
- def testAlertOnNewWindow(self):
- self._driver.Load(self.GetHttpUrlForFile('/chromedriver/empty.html'))
- old_windows = self._driver.GetWindowHandles()
- self._driver.ExecuteScript("window.open('%s')" %
- self.GetHttpUrlForFile('/chromedriver/alert_onload.html'))
- new_window = self.WaitForNewWindow(self._driver, old_windows)
- self.assertNotEqual(None, new_window)
- self._driver.SwitchToWindow(new_window)
- self.assertTrue(self._driver.IsAlertOpen())
- self._driver.HandleAlert(False)
- self.assertFalse(self._driver.IsAlertOpen())
def testShouldHandleNewWindowLoadingProperly(self):
"""Tests that ChromeDriver determines loading correctly for new windows."""
« no previous file with comments | « no previous file | chrome/test/data/chromedriver/alert_onload.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698