MIPS[64]: Support for some SIMD operations (3)

MIPS[64]: Support for some SIMD operations (3)

Add support for I32x4Mul, I32x4MaxS, I32x4MinS, I32x4Eq,
I32x4Ne, I32x4Shl, I32x4ShrS, I32x4ShrU, I32x4MaxU,
I32x4MinU, S32x4Select operations for mips32 and mips64
architectures

BUG=

Review-Url: https://codereview.chromium.org/2780713003
Cr-Commit-Position: refs/heads/master@{#44559}
Committed: https://chromium.googlesource.com/v8/v8/+/2468dacd69687346a02d2fe670b89e07a553eb4f

[dusan.simicic, 2017-03-28 10:17:14]

dusan.simicic@imgtec.com changed reviewers:
+ bbudge@chromium.org, ivica.bogosavljevic@imgtec.com, mtrofin@chromium.org,
titzer@chromium.org, v8-mips-ports@googlegroups.com

[dusan.simicic, 2017-03-28 10:17:15]

PTAL

[bbudge, 2017-03-28 17:18:27]

lgtm

[dusan.simicic, 2017-04-03 11:09:21]

Description was changed from

==========
MIPS[64]: Support for some SIMD operations (3)

Add support for Int32x4Mul, Int32x4Max, Int32x4Min, Int32x4Equal,
Int32x4NotEqual, Int32x4ShiftLeftByScalar, Int32x4ShiftRightByScalar,
Uint32x4ShiftRightByScalar, Uint32x4Max, Uint32x4Min, Simd32x4Select

BUG=
==========

to

==========
MIPS[64]: Support for some SIMD operations (3)

Add support for I32x4Mul, I32x4MaxS, I32x4MinS, I32x4Eq,
I32x4Ne, I32x4Shl, I32x4ShrS, I32x4ShrU, I32x4MaxU,
I32x4MinU, S32x4Select operations for mips32 and mips64
architectures

BUG=
==========

[ivica.bogosavljevic, 2017-04-05 13:00:53]

lgtm

https://codereview.chromium.org/2780713003/diff/20001/src/compiler/instructio...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/2780713003/diff/20001/src/compiler/instructio...
src/compiler/instruction-selector.cc:2114: !V8_TARGET_ARCH_MIPS64
What will happen if MIPS architecture doesn't support MSA?

[dusan.simicic, 2017-04-05 13:36:33]

https://codereview.chromium.org/2780713003/diff/20001/src/compiler/instructio...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/2780713003/diff/20001/src/compiler/instructio...
src/compiler/instruction-selector.cc:2114: !V8_TARGET_ARCH_MIPS64
On 2017/04/05 13:00:53, ivica.bogosavljevic wrote:
> What will happen if MIPS architecture doesn't support MSA?

If MSA instructions are not supported, SIMD operations from TF graph should be
lowered. CpuFeatures::SupportsWasmSimd128() is used for detection whether
lowering mechanism will be activated or not (wasm-compiler.cc:3871 and
cctest/wasm/wasm-run-utils.h:398).

[dusan.simicic, 2017-04-05 13:36:49]

The CQ bit was checked by dusan.simicic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 13:36:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 13:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 13:38:27]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/23934)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/38493)

[dusan.simicic, 2017-04-05 14:48:02]

The CQ bit was checked by dusan.simicic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 14:48:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 15:15:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 15:15:55]

Dry run: This issue passed the CQ dry run.

[dusan.simicic, 2017-04-06 14:38:04]

The CQ bit was checked by dusan.simicic@imgtec.com

[dusan.simicic, 2017-04-06 14:38:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
ivica.bogosavljevic@imgtec.com
Link to the patchset: https://codereview.chromium.org/2780713003/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2017-04-06 14:38:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 14:40:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 14:40:58]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/38600)

[dusan.simicic, 2017-04-06 14:54:51]

dusan.simicic@imgtec.com changed reviewers:
+ tebbi@google.com

[dusan.simicic, 2017-04-06 14:54:51]

+ tebbi for instruction-selector.cc

[dusan.simicic, 2017-04-11 09:25:19]

dusan.simicic@imgtec.com changed reviewers:
+ bmeurer@chromium.org

[dusan.simicic, 2017-04-11 09:25:19]

ping
+ bmeurer for instruction-selector.cc

[Tobias Tebbi, 2017-04-11 10:44:17]

On 2017/04/11 09:25:19, dusan.simicic wrote:
> ping
> + bmeurer for instruction-selector.cc

Sorry, didn't see the mail.

lgtm

[dusan.simicic, 2017-04-11 10:46:07]

The CQ bit was checked by dusan.simicic@imgtec.com

[commit-bot: I haz the power, 2017-04-11 10:46:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 11:11:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491907567311620,
"parent_rev": "2aaacddd4dd6d0cfcc56af9d3f36044d9d21f1a6", "commit_rev":
"2468dacd69687346a02d2fe670b89e07a553eb4f"}

[commit-bot: I haz the power, 2017-04-11 11:11:33]

Description was changed from

==========
MIPS[64]: Support for some SIMD operations (3)

Add support for I32x4Mul, I32x4MaxS, I32x4MinS, I32x4Eq,
I32x4Ne, I32x4Shl, I32x4ShrS, I32x4ShrU, I32x4MaxU,
I32x4MinU, S32x4Select operations for mips32 and mips64
architectures

BUG=
==========

to

==========
MIPS[64]: Support for some SIMD operations (3)

Add support for I32x4Mul, I32x4MaxS, I32x4MinS, I32x4Eq,
I32x4Ne, I32x4Shl, I32x4ShrS, I32x4ShrU, I32x4MaxU,
I32x4MinU, S32x4Select operations for mips32 and mips64
architectures

BUG=

Review-Url: https://codereview.chromium.org/2780713003
Cr-Commit-Position: refs/heads/master@{#44559}
Committed:
https://chromium.googlesource.com/v8/v8/+/2468dacd69687346a02d2fe670b89e07a55...
==========

[commit-bot: I haz the power, 2017-04-11 11:11:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/2468dacd69687346a02d2fe670b89e07a55...