Apply control clips in LayoutBox::clippingRect()

Apply control clips for LayoutBox::clippingRect().

BUG=704292
Review-Url: https://codereview.chromium.org/2780593002
Cr-Commit-Position: refs/heads/master@{#460154}
Committed: https://chromium.googlesource.com/chromium/src/+/5cc1a05a63f4db31cb3353de0909dd2a48b146f4

[chrishtr, 2017-03-27 17:28:07]

Description was changed from

==========
none


none


none

BUG=
==========

to

==========
Apply control clips for LayoutBox::clippingRect().

BUG=704292
==========

[chrishtr, 2017-03-27 17:31:55]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 17:32:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 18:14:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 18:14:26]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[chrishtr, 2017-03-27 20:05:18]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 20:05:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 21:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 21:58:15]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2017-03-28 03:20:00]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 03:20:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-28 03:20:33]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2017-03-28 03:20:34]

Followup to the other patch.

https://codereview.chromium.org/2780593002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
(right):

https://codereview.chromium.org/2780593002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt:30:
"position": [3, 3],
The rebaselines now apply a non-infinite clip as the child containment
layer of sublayers underneath a control clip.

[pdr., 2017-03-28 03:30:20]

LGTM

https://codereview.chromium.org/2780593002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (left):

https://codereview.chromium.org/2780593002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2353: 
Nit: remove this

https://codereview.chromium.org/2780593002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp (right):

https://codereview.chromium.org/2780593002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp:227: // Approximate
checks to avoid platform-specific clips.
Instead of approximate checks, can you check the OSX and non-OSX values exactly
like in PaintLayerClipperTest.cpp?

[chrishtr, 2017-03-28 03:52:14]

https://codereview.chromium.org/2780593002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp (right):

https://codereview.chromium.org/2780593002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp:227: // Approximate
checks to avoid platform-specific clips.
On 2017/03/28 at 03:30:20, pdr. wrote:
> Instead of approximate checks, can you check the OSX and non-OSX values
exactly like in PaintLayerClipperTest.cpp?

Sigh. Ok, will do.

[chrishtr, 2017-03-28 15:33:40]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-28 15:33:40]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2780593002/#ps140001
(title: "none")

[commit-bot: I haz the power, 2017-03-28 15:34:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 17:27:27]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1490715220325150,
"parent_rev": "3249950eb5a68320b971ec02e537c338be7f3a9c", "commit_rev":
"5cc1a05a63f4db31cb3353de0909dd2a48b146f4"}

[commit-bot: I haz the power, 2017-03-28 17:28:15]

Description was changed from

==========
Apply control clips for LayoutBox::clippingRect().

BUG=704292
==========

to

==========
Apply control clips for LayoutBox::clippingRect().

BUG=704292

Review-Url: https://codereview.chromium.org/2780593002
Cr-Commit-Position: refs/heads/master@{#460154}
Committed:
https://chromium.googlesource.com/chromium/src/+/5cc1a05a63f4db31cb3353de0909...
==========

[commit-bot: I haz the power, 2017-03-28 17:28:16]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/5cc1a05a63f4db31cb3353de0909...