Apply control clips in LayoutBox::clippingRect()

third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutBox.h"
 
 #include "core/html/HTMLElement.h"
 #include "core/layout/ImageQualityController.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 192 matching lines @@
   // The writing mode style should be still be inherited.
   EXPECT_TRUE(foreign->hasFlippedBlocksWritingMode());
 
   // The child of the foreign object is affected by writing-mode.
   EXPECT_EQ(foreign, child->locationContainer());
   EXPECT_EQ(LayoutRect(0, 0, 33, 55), child->frameRect());
   EXPECT_EQ(LayoutPoint(67, 0), child->physicalLocation());
   EXPECT_TRUE(child->hasFlippedBlocksWritingMode());
 }
 
+TEST_F(LayoutBoxTest, ControlClip) {
+  setBodyInnerHTML(
+      "<style>"
+      "  * { margin: 0; }"
+      "  #target {"
+      "    position: relative;"
+      "    width: 100px; height: 50px;"
+      "  }"
+      "</style>"
+      "<input id='target' type='button' value='some text'/>");
+  LayoutBox* target = toLayoutBox(getLayoutObjectByElementId("target"));
+  EXPECT_TRUE(target->hasControlClip());
+  EXPECT_TRUE(target->hasClipRelatedProperty());
+  EXPECT_TRUE(target->shouldClipOverflow());
+  // Approximate checks to avoid platform-specific clips.

[pdr., 2017/03/28 03:30:20]

Instead of approximate checks, can you check the OSX and non-OSX values exactly
like in PaintLayerClipperTest.cpp?

[chrishtr, 2017/03/28 03:52:14]

Sigh. Ok, will do.

+  EXPECT_LE(target->clippingRect().width().toInt(), 100);
+  EXPECT_LE(target->clippingRect().height().toInt(), 50);
+}
+
 }  // namespace blink