Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2780513006: Consider passing retries to be flake (Closed)

Created:
3 years, 8 months ago by smut
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Consider passing retries to be flake Considering it flake still logs the failure, but the return code will be zero and the step will be considered a success. BUG=704843 Review-Url: https://codereview.chromium.org/2780513006 Cr-Commit-Position: refs/heads/master@{#461256} Committed: https://chromium.googlesource.com/chromium/src/+/8e05f43c211c34bc5ad3f796021953d724e9f687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ios/build/bots/scripts/test_runner.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
smut
I'm told this is the correct behavior used by other platforms.
3 years, 8 months ago (2017-03-29 01:27:23 UTC) #3
Dirk Pranke
lgtm
3 years, 8 months ago (2017-03-30 23:43:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780513006/20001
3 years, 8 months ago (2017-03-31 21:58:22 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 22:36:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8e05f43c211c34bc5ad3f7960219...

Powered by Google App Engine
This is Rietveld 408576698