Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Unified Diff: ios/build/bots/scripts/test_runner.py

Issue 2780513006: Consider passing retries to be flake (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/build/bots/scripts/test_runner.py
diff --git a/ios/build/bots/scripts/test_runner.py b/ios/build/bots/scripts/test_runner.py
index 23d612487974feff00c7262ff0c643887d9ed18d..86392e85b2e0df7b242bfe35b207694d12a87272 100644
--- a/ios/build/bots/scripts/test_runner.py
+++ b/ios/build/bots/scripts/test_runner.py
@@ -376,10 +376,13 @@ class TestRunner(object):
print '%s tests failed and will be retried.' % len(failed)
print
for i in xrange(self.retries):
- for test in failed:
+ for test in failed.keys():
print 'Retry #%s for %s.' % (i + 1, test)
print
- self._run(self.get_launch_command(test_filter=[test]))
+ result = self._run(self.get_launch_command(test_filter=[test]))
+ # If the test passed on retry, consider it flake instead of failure.
+ if test in result.passed_tests:
+ flaked[test] = failed.pop(test)
# Build test_results.json.
self.test_results['interrupted'] = result.crashed
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698