Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2780513005: chromeos: Update note-taking apps when ARC-enabled profile added. (Closed)

Created:
3 years, 8 months ago by Daniel Erat
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

chromeos: Update note-taking apps when ARC-enabled profile added. Make NoteTakingHelper check new profiles' Play-Store-enabled states when they're added. It appears that OnArcPlayStoreEnabledChanged() is now not called in this case, resulting in the list of Android note-taking apps sometimes not being updated after login. BUG=700554 Review-Url: https://codereview.chromium.org/2777253002 Cr-Commit-Position: refs/heads/master@{#459921} (cherry picked from commit e96743eac963561dec6ec4d0f07f647cb27bc380) Review-Url: https://codereview.chromium.org/2780513005 . Cr-Commit-Position: refs/branch-heads/3029@{#464} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/1c6c8f43091d94665f6f7c16f0b7fd3995287b1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -3 lines) Patch
M chrome/browser/chromeos/note_taking_helper.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/note_taking_helper_unittest.cc View 3 chunks +40 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Daniel Erat
3 years, 8 months ago (2017-03-28 23:26:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c6c8f43091d94665f6f7c16f0b7fd3995287b1c.

Powered by Google App Engine
This is Rietveld 408576698