Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2780443002: SVGStringList update tests. (Closed)

Created:
3 years, 9 months ago by riju_
Modified:
3 years, 8 months ago
Reviewers:
fs
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

SVGStringList update tests. Update the SVGStringList tests to use a SVGStringList other than requiredFeatures, as we need to remove requiredFeatures. Fix SVGStringList-basics. Make SVGStringList.js use requiredExtensions instead of requiredFeatures. BUG=635420 Review-Url: https://codereview.chromium.org/2780443002 Cr-Commit-Position: refs/heads/master@{#460120} Committed: https://chromium.googlesource.com/chromium/src/+/e6fbe0502934c1d8d4f72c4197e10d2b99879c85

Patch Set 1 #

Patch Set 2 : Rebaseline for SVGStringList-basics.xhtml #

Patch Set 3 : requiredFeatures->requiredExtensions in svgdom-over-01-f.svg, external/wpt/svg/interfaces.html #

Patch Set 4 : Rebaselining svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg and win:svg/dom/SVGStringList-basics.xhtml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+425 lines, -425 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/svg/interfaces.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/svg/interfaces-expected.txt View 1 2 1 chunk +17 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/dom/SVGStringList-basics-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/dom/SVGStringList-basics-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.11/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/dom/SVGStringList-basics-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/dom/SVGStringList-basics-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt View 1 2 3 3 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/dom/SVGStringList-basics-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGStringList-basics.xhtml View 2 chunks +193 lines, -193 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGStringList-basics-expected.txt View 1 chunk +171 lines, -171 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGStringList-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGStringList.js View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
riju_
Hi Fredrick, PTAL. I made this CL as per your comments in https://codereview.chromium.org/2741463002/#msg25
3 years, 8 months ago (2017-03-28 16:03:27 UTC) #16
fs
lgtm
3 years, 8 months ago (2017-03-28 16:09:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780443002/60001
3 years, 8 months ago (2017-03-28 16:15:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780443002/60001
3 years, 8 months ago (2017-03-28 16:16:45 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 16:27:23 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e6fbe0502934c1d8d4f72c4197e1...

Powered by Google App Engine
This is Rietveld 408576698