Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2780433005: Convert AudioParam tests to new Audit (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert AudioParam tests to new Audit Manually converted test to use new Audit. BUG=704967 TEST= AudioParam/audioparam-automation-clamping.html AudioParam/audioparam-clamp-time-to-current-time.html AudioParam/audioparam-initial-event.html AudioParam/audioparam-large-endtime.html AudioParam/audioparam-linearRamp-value-attribute.html AudioParam/audioparam-method-chaining.html AudioParam/audioparam-negative-exponentialRamp.html AudioParam/audioparam-nominal-range.html AudioParam/audioparam-processing.html AudioParam/audioparam-sampling.html AudioParam/audioparam-setTarget-timeConstant-0.html AudioParam/audioparam-setTargetAtTime-continuous.html AudioParam/audioparam-setTargetAtTime-limit.html AudioParam/audioparam-setTargetAtTime-sampling.html AudioParam/audioparam-setValueCurve-copy.html AudioParam/audioparam-setValueCurve-duration.html AudioParam/audioparam-setValueCurve-end.html AudioParam/audioparam-setValueCurve-exceptions.html AudioParam/audioparam-setValueCurveAtTime-interpolation.html AudioParam/audioparam-update-value-attribute.html Review-Url: https://codereview.chromium.org/2780433005 Cr-Commit-Position: refs/heads/master@{#462499} Committed: https://chromium.googlesource.com/chromium/src/+/a98570a5b245176fafb0a2b30d8c0b302cc28dec

Patch Set 1 #

Patch Set 2 : Rebaseline expected results #

Patch Set 3 : Indent long lines #

Total comments: 3

Patch Set 4 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+909 lines, -965 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping.html View 1 2 5 chunks +12 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt View 1 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-clamp-time-to-current-time.html View 1 2 8 chunks +52 lines, -83 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-initial-event.html View 4 chunks +20 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-large-endtime.html View 2 chunks +12 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-linearRamp-value-attribute.html View 1 2 3 chunks +10 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html View 1 2 4 chunks +31 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-negative-exponentialRamp.html View 6 chunks +15 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html View 1 2 13 chunks +51 lines, -45 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range-expected.txt View 1 2 1 chunk +315 lines, -263 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-processing.html View 5 chunks +53 lines, -55 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-sampling.html View 5 chunks +10 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTarget-timeConstant-0.html View 3 chunks +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-continuous.html View 1 2 8 chunks +31 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-limit.html View 1 2 8 chunks +16 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html View 1 2 4 chunks +30 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-copy.html View 3 chunks +5 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-duration.html View 3 chunks +6 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-end.html View 1 2 3 chunks +11 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html View 1 2 3 6 chunks +121 lines, -116 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt View 1 2 1 chunk +45 lines, -38 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html View 1 2 7 chunks +30 lines, -47 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html View 9 chunks +19 lines, -26 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-05 17:43:03 UTC) #2
hongchan
lgtm with nit https://codereview.chromium.org/2780433005/diff/40001/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html File third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html (right): https://codereview.chromium.org/2780433005/diff/40001/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html#newcode34 third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html:34: should(function () { Perhaps () => ...
3 years, 8 months ago (2017-04-05 21:42:09 UTC) #3
Raymond Toy
https://codereview.chromium.org/2780433005/diff/40001/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html File third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html (right): https://codereview.chromium.org/2780433005/diff/40001/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html#newcode34 third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html:34: should(function () { On 2017/04/05 21:42:09, hongchan wrote: > ...
3 years, 8 months ago (2017-04-05 21:51:58 UTC) #4
hongchan
On 2017/04/05 21:51:58, Raymond Toy wrote: > https://codereview.chromium.org/2780433005/diff/40001/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html > File > third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html > (right): > ...
3 years, 8 months ago (2017-04-05 21:54:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780433005/60001
3 years, 8 months ago (2017-04-05 21:57:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/389570)
3 years, 8 months ago (2017-04-05 22:05:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780433005/60001
3 years, 8 months ago (2017-04-06 15:30:06 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 15:58:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a98570a5b245176fafb0a2b30d8c...

Powered by Google App Engine
This is Rietveld 408576698