Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1616)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-duration.html

Issue 2780433005: Convert AudioParam tests to new Audit (Closed)
Patch Set: Address review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-duration.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-duration.html b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-duration.html
index 0368e130a86c28c780d2ccc52def5114389c80e5..83bd56756654e1371dc999cfe7d5b86a7e4da43a 100644
--- a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-duration.html
+++ b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-duration.html
@@ -4,7 +4,7 @@
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
- <script src="../resources/audio-testing.js"></script>
+ <script src="../resources/audit.js"></script>
<script src="../resources/audioparam-testing.js"></script>
<title>Test setValueCurveAtTime with Huge Duration</title>
</head>
@@ -17,7 +17,7 @@
var audit = Audit.createTaskRunner();
- audit.defineTask("long duration", function (done) {
+ audit.define("long duration", (task, should) => {
// We only need to generate a small number of frames for this test.
var context = new OfflineAudioContext(1, renderFrames, sampleRate);
var src = context.createBufferSource();
@@ -50,21 +50,12 @@
var message = "setValueCurve([" + curve + "], 0, " + duration + ")";
- success = Should("Max amplitude of " + message, max, {
- brief: true
- }).beLessThanOrEqualTo(expectedMax);
-
- Should(message, success)
- .summarize("correctly rounded",
- "incorrectly rendered with a peak value of " + max);
- }).then(done);
- });
-
- audit.defineTask("finish", function (done) {
- done();
+ should(max, "Max amplitude of " + message)
+ .beLessThanOrEqualTo(expectedMax);
+ }).then(() => task.done());
});
- audit.runTasks();
+ audit.run();
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698