Create core/html/media/ and move auxiliary media files in it.

Create core/html/media/ and move auxiliary media files in it.

This is moving all media files from core/html/ into this new directory
except the HTML elements implementation and their tests. It helps with
the teamification effort and will help with reviews for these files.

This is also moving HTMLMediaElementControlsList.h include out of
HTMLMediaElement.h and forward declare the class instead. In order to do so
a new controlsListInternal() was added for non-binding usage.

BUG=None
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2780403004
Cr-Commit-Position: refs/heads/master@{#461691}
Committed: https://chromium.googlesource.com/chromium/src/+/bde3cb9a20397d9e227162246b7e40d3251d2016

[mlamouri (slow - plz ping), 2017-03-30 20:29:08]

mlamouri@chromium.org changed reviewers:
+ avayvod@chromium.org, zqzhang@chromium.org

[mlamouri (slow - plz ping), 2017-03-30 20:29:09]

foolip@, PTAL. I did not include you in the OWNERS file as you are trying to
move away from this land. I'm happy to add you though :)

+avayvod@, +zqzhang@ FYI :)

[mlamouri (slow - plz ping), 2017-03-31 09:12:53]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 09:13:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 10:46:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 10:46:59]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-04-03 16:41:29]

foolip@, friendly ping :)

[whywhat, 2017-04-04 02:28:21]

lgtm

[foolip, 2017-04-04 09:12:55]

lgtm % the bit I don't understand

https://codereview.chromium.org/2780403004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/2780403004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.h:207: DOMTokenList*
controlsList() const;
Why was this change needed? HTMLMediaElementControlsList doesn't seem to have
changed in this CL.

[mlamouri (slow - plz ping), 2017-04-04 09:19:43]

Description was changed from

==========
Create core/html/media/ and move auxiliary media files in it.

This is moving all media files from core/html/ into this new directory
except the HTML elements implementation and their tests. It helps with
the teamification effort and will help with reviews for these files.

BUG=None
R=foolip@chromium.org
==========

to

==========
Create core/html/media/ and move auxiliary media files in it.

This is moving all media files from core/html/ into this new directory
except the HTML elements implementation and their tests. It helps with
the teamification effort and will help with reviews for these files.

This is also moving HTMLMediaElementControlsList.h include out of
HTMLMediaElement.h and forward declare the class instead. In order to do so
a new controlsListInternal() was added for non-binding usage.

BUG=None
R=foolip@chromium.org
==========

[mlamouri (slow - plz ping), 2017-04-04 09:19:51]

https://codereview.chromium.org/2780403004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/2780403004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.h:207: DOMTokenList*
controlsList() const;
On 2017/04/04 at 09:12:55, foolip_UTC7 wrote:
> Why was this change needed? HTMLMediaElementControlsList doesn't seem to have
changed in this CL.

I removed the include and replaced it with a forward declaration. I ended up
solving the reason why avayvod@ put an include in the first place (the bindings
are calling controlsList() and can't convert to DOMTokenList unless they know of
HTMLMediaElementControlsList. I will update the description to make this clear.

[mlamouri (slow - plz ping), 2017-04-04 09:19:58]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2017-04-04 09:20:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2017-04-04 09:24:36]

https://codereview.chromium.org/2780403004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/2780403004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.h:207: DOMTokenList*
controlsList() const;
On 2017/04/04 09:19:51, mlamouri wrote:
> On 2017/04/04 at 09:12:55, foolip_UTC7 wrote:
> > Why was this change needed? HTMLMediaElementControlsList doesn't seem to
have
> changed in this CL.
> 
> I removed the include and replaced it with a forward declaration. I ended up
> solving the reason why avayvod@ put an include in the first place (the
bindings
> are calling controlsList() and can't convert to DOMTokenList unless they know
of
> HTMLMediaElementControlsList. I will update the description to make this
clear.

Acknowledged.

[commit-bot: I haz the power, 2017-04-04 13:11:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491297598054640,
"parent_rev": "656fccff69eae8da012f0f83bcd3fc89214c5258", "commit_rev":
"bde3cb9a20397d9e227162246b7e40d3251d2016"}

[commit-bot: I haz the power, 2017-04-04 13:12:32]

Description was changed from

==========
Create core/html/media/ and move auxiliary media files in it.

This is moving all media files from core/html/ into this new directory
except the HTML elements implementation and their tests. It helps with
the teamification effort and will help with reviews for these files.

This is also moving HTMLMediaElementControlsList.h include out of
HTMLMediaElement.h and forward declare the class instead. In order to do so
a new controlsListInternal() was added for non-binding usage.

BUG=None
R=foolip@chromium.org
==========

to

==========
Create core/html/media/ and move auxiliary media files in it.

This is moving all media files from core/html/ into this new directory
except the HTML elements implementation and their tests. It helps with
the teamification effort and will help with reviews for these files.

This is also moving HTMLMediaElementControlsList.h include out of
HTMLMediaElement.h and forward declare the class instead. In order to do so
a new controlsListInternal() was added for non-binding usage.

BUG=None
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2780403004
Cr-Commit-Position: refs/heads/master@{#461691}
Committed:
https://chromium.googlesource.com/chromium/src/+/bde3cb9a20397d9e227162246b7e...
==========

[commit-bot: I haz the power, 2017-04-04 13:12:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bde3cb9a20397d9e227162246b7e...