third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp - Issue 2780403004: Create core/html/media/ and move auxiliary media files in it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 2780403004: Create core/html/media/ and move auxiliary media files in it. (Closed)

Patch Set: actually add autoplay files Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLMediaElement.h ('K') | « third_party/WebKit/Source/core/html/media/OWNERS ('k') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

index 56f2ac372f8d6d4c522ac91ddad70933705e95f9..55219fde43fcdb52e3e047a5ecfe2b37fffd9e86 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

@@ -41,10 +41,11 @@

#include "core/frame/UseCounter.h"

#include "core/html/HTMLAnchorElement.h"

#include "core/html/HTMLLabelElement.h"

-#include "core/html/HTMLMediaSource.h"

#include "core/html/HTMLSpanElement.h"

#include "core/html/HTMLVideoElement.h"

#include "core/html/TimeRanges.h"

+#include "core/html/media/HTMLMediaElementControlsList.h"

+#include "core/html/media/HTMLMediaSource.h"

#include "core/html/shadow/MediaControls.h"

#include "core/html/track/TextTrackList.h"

#include "core/input/EventHandler.h"

@@ -708,7 +709,7 @@ bool MediaControlDownloadButtonElement::shouldDisplayDownloadButton() {

return false;

// The attribute disables the download button.

- if (mediaElement().controlsList()->shouldHideDownload()) {

+ if (mediaElement().controlsListInternal()->shouldHideDownload()) {

UseCounter::count(mediaElement().document(),

UseCounter::HTMLMediaElementControlsListNoDownload);

return false;