chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java - Issue 2780403002: WebView: change default shouldOverrideUrlLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 2780403002: WebView: change default shouldOverrideUrlLoading (Closed)

Patch Set: Squash commits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

index 80f0970d0f1ff340126b095e7feb0271d285125f..8626450a8c07a3477c96f795eddc036695c8f204 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

@@ -17,7 +17,6 @@ import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

-import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.compositor.bottombar.OverlayContentDelegate;

import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.PanelState;

import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;

@@ -49,6 +48,7 @@ import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.content_public.browser.NavigationEntry;

import org.chromium.content_public.browser.WebContents;

import org.chromium.content_public.common.BrowserControlsState;

+import org.chromium.content_public.common.ContentUrlConstants;

import org.chromium.net.NetworkChangeNotifier;

import org.chromium.ui.base.WindowAndroid;

@@ -76,7 +76,7 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega

private static final long INTERCEPT_NAVIGATION_PROMOTION_ANIMATION_DURATION_MS = 40;

// We blacklist this URL because malformed URLs may bring up this page.

- private static final String BLACKLISTED_URL = UrlConstants.ABOUT_BLANK_DISPLAY_URL;

+ private static final String BLACKLISTED_URL = ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL;

private static final Pattern CONTAINS_WHITESPACE_PATTERN = Pattern.compile("\\s");