chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java - Issue 2780403002: WebView: change default shouldOverrideUrlLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 2780403002: WebView: change default shouldOverrideUrlLoading (Closed)

Patch Set: Squash commits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

index 7e3bdec27e4615309d37f26254b465b783038dc1..bd9bf13c1bb36e78f542508ff26785b25a0ef0af 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

@@ -16,12 +16,12 @@ import android.webkit.MimeTypeMap;

import org.chromium.base.CollectionUtil;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.firstrun.FirstRunStatus;

import org.chromium.chrome.browser.preferences.ChromePreferenceManager;

import org.chromium.chrome.browser.preferences.datareduction.DataReductionProxyUma;

import org.chromium.chrome.browser.search_engines.TemplateUrlService;

import org.chromium.chrome.browser.util.UrlUtilities;

+import org.chromium.content_public.common.ContentUrlConstants;

import java.lang.annotation.Retention;

import java.lang.annotation.RetentionPolicy;

@@ -235,7 +235,7 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {

public static String createHeaderText(ContextMenuParams params) {

String titleText = "";

if (!TextUtils.isEmpty(params.getLinkUrl())

- && !params.getLinkUrl().equals(UrlConstants.ABOUT_BLANK_DISPLAY_URL)) {

+ && !params.getLinkUrl().equals(ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL)) {

titleText = params.getLinkUrl();

} else if (!TextUtils.isEmpty(params.getTitleText())) {

titleText = params.getTitleText();

@@ -397,7 +397,7 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {

}

if (TextUtils.isEmpty(params.getLinkUrl())

- || params.getLinkUrl().equals(UrlConstants.ABOUT_BLANK_DISPLAY_URL)) {

+ || params.getLinkUrl().equals(ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL)) {

disabledOptions.add(ContextMenuItem.OPEN_IN_OTHER_WINDOW);

disabledOptions.add(ContextMenuItem.OPEN_IN_NEW_TAB);

disabledOptions.add(ContextMenuItem.OPEN_IN_INCOGNITO_TAB);