chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java - Issue 2780403002: WebView: change default shouldOverrideUrlLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

Issue 2780403002: WebView: change default shouldOverrideUrlLoading (Closed)

Patch Set: Squash commits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

index ef2a3af16c99a58e4a13b0d99bdb3990ecf946bf..b55cb35573e489e953ecfa32da82b40a3b23e5b9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

@@ -29,6 +29,7 @@ import org.chromium.chrome.browser.tab.TabRedirectHandler;

import org.chromium.chrome.browser.util.IntentUtils;

import org.chromium.chrome.browser.util.UrlUtilities;

import org.chromium.chrome.browser.webapps.ChromeWebApkHost;

+import org.chromium.content_public.common.ContentUrlConstants;

import org.chromium.ui.base.PageTransition;

import java.net.URI;

@@ -310,7 +311,7 @@ public class ExternalNavigationHandler {

// The "about:", "chrome:", and "chrome-native:" schemes are internal to the browser;

// don't want these to be dispatched to other apps.

- if (params.getUrl().startsWith(UrlConstants.ABOUT_URL_SHORT_PREFIX)

+ if (params.getUrl().startsWith(ContentUrlConstants.ABOUT_URL_SHORT_PREFIX)

|| params.getUrl().startsWith(UrlConstants.CHROME_URL_SHORT_PREFIX)

|| params.getUrl().startsWith(UrlConstants.CHROME_NATIVE_URL_SHORT_PREFIX)) {

if (DEBUG) Log.i(TAG, "NO_OVERRIDE: Navigating to a chrome-internal page");