Always disable the beforeunload timer when injecting the beforeunload method.

Always disable the beforeunload timer when injecting the beforeunload method.

BUG=705306
TEST=Linux MSan Tests goes green

Review-Url: https://codereview.chromium.org/2780343002
Cr-Commit-Position: refs/heads/master@{#460884}
Committed: https://chromium.googlesource.com/chromium/src/+/4588bf925fa2b0aae2462cda08c7066886b09dcc

[Avi (use Gerrit), 2017-03-30 00:09:26]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 00:10:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-03-30 00:12:18]

avi@chromium.org changed reviewers:
+ thakis@chromium.org

[Avi (use Gerrit), 2017-03-30 00:12:18]

Nico,

The old code had used a command-line flag to disable the timer across the entire
test, and my previous CL switched to using new API in the core function called
by the tests that needed the timer disabling...

except for one test.

This moves the disabling to the function InjectBeforeUnloadListener(), so that
any test that injects the beforeunload listener will correctly disable the hang
timer.

I guarantee that this will clear the devtools browser_tests failure from Linux
MSan Tests. :)

[Avi (use Gerrit), 2017-03-30 00:25:45]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 00:26:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 02:28:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 02:28:51]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[Avi (use Gerrit), 2017-03-30 15:29:57]

avi@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org
- thakis@chromium.org

[Avi (use Gerrit), 2017-03-30 15:29:58]

Oops, Nico is AFK.

This is one last test deflaker. Every time we inject a beforeunload we need to
make sure that the timer is off, so put the code to do so in the function that
injects the beforeunload.

PTAL

https://codereview.chromium.org/2780343002/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_sanity_browsertest.cc (right):

https://codereview.chromium.org/2780343002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/devtools_sanity_browsertest.cc:824:
DevToolsWindowTesting::Get(windows[2])->main_web_contents());
This is the second spot where InjectBeforeUnloadListener() is called. Putting
the timeout kill into InjectBeforeUnloadListener() fixes this test too.

[dgozman, 2017-03-30 20:35:44]

lgtm

[Avi (use Gerrit), 2017-03-30 21:10:01]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-03-30 21:10:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 21:28:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490908201400600,
"parent_rev": "d60dd81592ee6fb3ecc4acf33d88874c7444eea0", "commit_rev":
"4588bf925fa2b0aae2462cda08c7066886b09dcc"}

[commit-bot: I haz the power, 2017-03-30 21:28:58]

Description was changed from

==========
Always disable the beforeunload timer when injecting the beforeunload method.

BUG=705306
TEST=Linux MSan Tests goes green
==========

to

==========
Always disable the beforeunload timer when injecting the beforeunload method.

BUG=705306
TEST=Linux MSan Tests goes green

Review-Url: https://codereview.chromium.org/2780343002
Cr-Commit-Position: refs/heads/master@{#460884}
Committed:
https://chromium.googlesource.com/chromium/src/+/4588bf925fa2b0aae2462cda08c7...
==========

[commit-bot: I haz the power, 2017-03-30 21:28:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4588bf925fa2b0aae2462cda08c7...