Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest.

Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest.

They were attempting to disable the beforeunload timeout, but the switch provided no longer worked.

BUG=705306, 418266, 700271, 700641
TEST=Linux MSan Tests goes green
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng

Review-Url: https://codereview.chromium.org/2777013004
Cr-Commit-Position: refs/heads/master@{#460472}
Committed: https://chromium.googlesource.com/chromium/src/+/64b8b65b733a3ac8bd0b5f707431f6d1fae20948

[Avi (use Gerrit), 2017-03-28 02:31:36]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2017-03-28 02:31:37]

Description was changed from

==========
Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest.

They were accidentally relying on the implementation detail of the hang monitor
running the beforeunload timeout, which is no longer the case.

BUG=705306, 418266, 700271, 700641
TEST=Linux MSan Tests goes green
==========

to

==========
Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest.

They were accidentally relying on the implementation detail of the hang monitor
running the beforeunload timeout, which is no longer the case.

BUG=705306, 418266, 700271, 700641
TEST=Linux MSan Tests goes green
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-03-28 02:32:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-03-28 02:34:58]

Description was changed from

==========
Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest.

They were accidentally relying on the implementation detail of the hang monitor
running the beforeunload timeout, which is no longer the case.

BUG=705306, 418266, 700271, 700641
TEST=Linux MSan Tests goes green
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest.

They were accidentally relying on the implementation detail of the hang monitor
running the beforeunload timeout, which is no longer the case.

BUG=705306, 418266, 700271, 700641
TEST=Linux MSan Tests goes green
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng
==========

[Avi (use Gerrit), 2017-03-28 02:35:10]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2017-03-28 02:35:18]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 02:35:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 03:25:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 03:25:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2017-03-28 14:41:50]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 14:42:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-03-28 14:47:02]

Description was changed from

==========
Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest.

They were accidentally relying on the implementation detail of the hang monitor
running the beforeunload timeout, which is no longer the case.

BUG=705306, 418266, 700271, 700641
TEST=Linux MSan Tests goes green
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng
==========

to

==========
Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest.

They were attempting to disable the beforeunload timeout, but the switch
provided no longer worked.

BUG=705306, 418266, 700271, 700641
TEST=Linux MSan Tests goes green
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng
==========

[commit-bot: I haz the power, 2017-03-28 16:34:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 16:34:32]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-03-28 16:54:46]

avi@chromium.org changed reviewers:
+ nasko@chromium.org, pfeldman@chromium.org, thakis@chromium.org

[Avi (use Gerrit), 2017-03-28 16:54:47]

Nasko: content guts
Nico: BrowserCloseManagerBrowserTest
Pavel: devtools

[nasko, 2017-03-28 17:55:43]

content/ LGTM

[Nico, 2017-03-28 19:29:34]

chrome/ lgtm

[Avi (use Gerrit), 2017-03-29 15:02:40]

avi@chromium.org changed reviewers:
+ dgozman@chromium.org

[Avi (use Gerrit), 2017-03-29 15:02:41]

The devtools part of this review is incidental. Can I get a review, pfeldman,
dgozman? I'm trying to help in getting a bot green.

[dgozman, 2017-03-29 16:31:39]

lgtm

[Avi (use Gerrit), 2017-03-29 16:34:04]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-03-29 16:34:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 18:50:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490805244767240,
"parent_rev": "33295fdb5fa26e409b197b81b2069c435184d6e3", "commit_rev":
"64b8b65b733a3ac8bd0b5f707431f6d1fae20948"}

[commit-bot: I haz the power, 2017-03-29 18:55:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490805244767240,
"parent_rev": "33295fdb5fa26e409b197b81b2069c435184d6e3", "commit_rev":
"64b8b65b733a3ac8bd0b5f707431f6d1fae20948"}

[commit-bot: I haz the power, 2017-03-29 18:55:39]

Description was changed from

==========
Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest.

They were attempting to disable the beforeunload timeout, but the switch
provided no longer worked.

BUG=705306, 418266, 700271, 700641
TEST=Linux MSan Tests goes green
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng
==========

to

==========
Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest.

They were attempting to disable the beforeunload timeout, but the switch
provided no longer worked.

BUG=705306, 418266, 700271, 700641
TEST=Linux MSan Tests goes green
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng

Review-Url: https://codereview.chromium.org/2777013004
Cr-Commit-Position: refs/heads/master@{#460472}
Committed:
https://chromium.googlesource.com/chromium/src/+/64b8b65b733a3ac8bd0b5f707431...
==========

[commit-bot: I haz the power, 2017-03-29 18:55:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/64b8b65b733a3ac8bd0b5f707431...