Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2780303002: Persist HTTP RTT and Transport RTT estimates in UKM on navigation start. (Closed)

Created:
3 years, 8 months ago by tbansal1
Modified:
3 years, 8 months ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Persist HTTP RTT and Transport RTT estimates in UKM on navigation start. This change emits a UKM PageLoad metric for the HTTP RTT estimate, and one for the transport RTT estimate at navigation start. BUG=706590 Review-Url: https://codereview.chromium.org/2780303002 Cr-Commit-Position: refs/heads/master@{#460613} Committed: https://chromium.googlesource.com/chromium/src/+/4ef70d6e83c712b52c7e46e16fbd1d9636299567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc View 5 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
tbansal1
bmcquade: ptal. Thanks.
3 years, 8 months ago (2017-03-29 22:28:02 UTC) #3
Bryan McQuade
On 2017/03/29 at 22:28:02, tbansal wrote: > bmcquade: ptal. Thanks. LGTM, thanks!
3 years, 8 months ago (2017-03-30 00:58:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780303002/1
3 years, 8 months ago (2017-03-30 01:03:33 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 01:11:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ef70d6e83c712b52c7e46e16fbd...

Powered by Google App Engine
This is Rietveld 408576698