Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1866)

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

Issue 2780303002: Persist HTTP RTT and Transport RTT estimates in UKM on navigation start. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
index 6b165925a225b2787743c681939652a561d399cc..981cdc0bdf820e257c805d9f71a18651b2435bb0 100644
--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
@@ -6,6 +6,8 @@
#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_UKM_PAGE_LOAD_METRICS_OBSERVER_H_
#include "base/macros.h"
+#include "base/optional.h"
+#include "base/time/time.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
#include "net/nqe/network_quality_estimator.h"
#include "ui/base/page_transition_types.h"
@@ -27,6 +29,8 @@ extern const char kUkmForegroundDurationName[];
extern const char kUkmFailedProvisionaLoadName[];
extern const char kUkmNetErrorCode[];
extern const char kUkmEffectiveConnectionType[];
+extern const char kUkmHttpRttEstimate[];
+extern const char kUkmTransportRttEstimate[];
extern const char kUkmPageTransition[];
} // namespace internal
@@ -85,8 +89,11 @@ class UkmPageLoadMetricsObserver
// Unique UKM identifier for the page load we are recording metrics for.
const int32_t source_id_;
+ // Network quality estimates.
net::EffectiveConnectionType effective_connection_type_ =
net::EFFECTIVE_CONNECTION_TYPE_UNKNOWN;
+ base::Optional<base::TimeDelta> http_rtt_estimate_;
+ base::Optional<base::TimeDelta> transport_rtt_estimate_;
// PAGE_TRANSITION_LINK is the default PageTransition value.
ui::PageTransition page_transition_ = ui::PAGE_TRANSITION_LINK;
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698