Fix caret visual rect on compositing change

Fix caret visual rect on compositing change

We should not clear CaretDisplayItemClient::m_localRect in
CaretDisplayItemClient::clearPreviousVisualRects() (which is called
on compositing change) because
- it doesn't change on compositing change;
- compositing change happens after updateStyleAndLayoutIfNeeded();
- we'll need m_localRect to calculate the new visual rect during paint
  invalidation.

BUG=704443
TBR=wangxianzhu@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2777183003
Cr-Original-Commit-Position: refs/heads/master@{#459833}
Review-Url: https://codereview.chromium.org/2779953002
Cr-Commit-Position: refs/branch-heads/3029@{#455}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/09159c33fefdbea144d2baf6485736f922ed8c08

[Xianzhu, 2017-03-28 18:31:55]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-28 18:32:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 18:34:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490725915716400, "parent_rev":
"28c149b38283f61613fa2bea8da7e584df30a68c", "commit_rev":
"09159c33fefdbea144d2baf6485736f922ed8c08"}

[commit-bot: I haz the power, 2017-03-28 18:35:43]

Description was changed from

==========
Fix caret visual rect on compositing change

We should not clear CaretDisplayItemClient::m_localRect in
CaretDisplayItemClient::clearPreviousVisualRects() (which is called
on compositing change) because
- it doesn't change on compositing change;
- compositing change happens after updateStyleAndLayoutIfNeeded();
- we'll need m_localRect to calculate the new visual rect during paint
  invalidation.

BUG=704443
TBR=wangxianzhu@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2777183003
Cr-Commit-Position: refs/heads/master@{#459833}
==========

to

==========
Fix caret visual rect on compositing change

We should not clear CaretDisplayItemClient::m_localRect in
CaretDisplayItemClient::clearPreviousVisualRects() (which is called
on compositing change) because
- it doesn't change on compositing change;
- compositing change happens after updateStyleAndLayoutIfNeeded();
- we'll need m_localRect to calculate the new visual rect during paint
  invalidation.

BUG=704443
TBR=wangxianzhu@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2777183003
Cr-Original-Commit-Position: refs/heads/master@{#459833}
Review-Url: https://codereview.chromium.org/2779953002
Cr-Commit-Position: refs/branch-heads/3029@{#455}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/09159c33fefdbea144d2baf64857...
==========

[commit-bot: I haz the power, 2017-03-28 18:35:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/09159c33fefdbea144d2baf64857...