Fix caret visual rect on compositing change

Fix caret visual rect on compositing change

We should not clear CaretDisplayItemClient::m_localRect in
CaretDisplayItemClient::clearPreviousVisualRects() (which is called
on compositing change) because
- it doesn't change on compositing change;
- compositing change happens after updateStyleAndLayoutIfNeeded();
- we'll need m_localRect to calculate the new visual rect during paint
  invalidation.

BUG=704443
Review-Url: https://codereview.chromium.org/2777183003
Cr-Commit-Position: refs/heads/master@{#459833}
Committed: https://chromium.googlesource.com/chromium/src/+/8f35a712fd404645efbc73aa8a1ce71d6d0078c0

[Xianzhu, 2017-03-27 16:46:04]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 16:46:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-03-27 16:47:11]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2017-03-27 16:48:45]

Description was changed from

==========
Fix caret visual rect on compositing change

We should not clear CaretDisplayItemClient::m_localRect in
CaretDisplayItemClient::clearPreviousVisualRects() (which is called
on compositing change) because
- it doesn't change on compositing change;
- we'll need it to calculate the new visual rect.

BUG=704443
==========

to

==========
Fix caret visual rect on compositing change

We should not clear CaretDisplayItemClient::m_localRect in
CaretDisplayItemClient::clearPreviousVisualRects() (which is called
on compositing change) because
- it doesn't change on compositing change;
- compositing change happens after updateStyleAndLayoutIfNeeded();
- we'll need m_localRect to calculate the new visual rect during paint
  invalidation.

BUG=704443
==========

[chrishtr, 2017-03-27 16:49:19]

lgtm

[Xianzhu, 2017-03-27 16:59:51]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-27 16:59:55]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-27 17:00:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 18:24:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490633995321350, "parent_rev":
"30ad2e95a5f0c052b2cf7c909d8c84b294e66b0b", "commit_rev":
"8f35a712fd404645efbc73aa8a1ce71d6d0078c0"}

[commit-bot: I haz the power, 2017-03-27 18:25:27]

Description was changed from

==========
Fix caret visual rect on compositing change

We should not clear CaretDisplayItemClient::m_localRect in
CaretDisplayItemClient::clearPreviousVisualRects() (which is called
on compositing change) because
- it doesn't change on compositing change;
- compositing change happens after updateStyleAndLayoutIfNeeded();
- we'll need m_localRect to calculate the new visual rect during paint
  invalidation.

BUG=704443
==========

to

==========
Fix caret visual rect on compositing change

We should not clear CaretDisplayItemClient::m_localRect in
CaretDisplayItemClient::clearPreviousVisualRects() (which is called
on compositing change) because
- it doesn't change on compositing change;
- compositing change happens after updateStyleAndLayoutIfNeeded();
- we'll need m_localRect to calculate the new visual rect during paint
  invalidation.

BUG=704443

Review-Url: https://codereview.chromium.org/2777183003
Cr-Commit-Position: refs/heads/master@{#459833}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f35a712fd404645efbc73aa8a1c...
==========

[commit-bot: I haz the power, 2017-03-27 18:25:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f35a712fd404645efbc73aa8a1c...