Removes the displayed cell in the ReadingList item

Removes the displayed cell in the ReadingList item

The Reading List item had a pointer to the cell displayed. This does not work
with auto layout.

BUG=705881
Review-Url: https://codereview.chromium.org/2779893003
Cr-Commit-Position: refs/heads/master@{#460324}
Committed: https://chromium.googlesource.com/chromium/src/+/eee1c04986aabbf73c763b913c33d0d538f3ad5f

[gambard, 2017-03-28 08:37:35]

gambard@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[gambard, 2017-03-28 08:37:35]

PTAL

[Olivier, 2017-03-28 08:52:07]

LGTM, 2 questions

https://codereview.chromium.org/2779893003/diff/1/ios/chrome/browser/ui/readi...
File
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
(right):

https://codereview.chromium.org/2779893003/diff/1/ios/chrome/browser/ui/readi...
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm:593:
ReadingListCollectionViewItem* newItem = iterator->second;
If an item is inserted (and index is not synchronized with iterator anymore),
does it reload all items?

https://codereview.chromium.org/2779893003/diff/1/ios/chrome/browser/ui/readi...
File ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
(right):

https://codereview.chromium.org/2779893003/diff/1/ios/chrome/browser/ui/readi...
ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h:58:
@property(nonatomic, readonly, strong) FaviconViewNew* faviconView;
Not for this CL, but why New?

[gambard, 2017-03-28 09:43:14]

Thanks!

https://codereview.chromium.org/2779893003/diff/1/ios/chrome/browser/ui/readi...
File
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
(right):

https://codereview.chromium.org/2779893003/diff/1/ios/chrome/browser/ui/readi...
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm:593:
ReadingListCollectionViewItem* newItem = iterator->second;
On 2017/03/28 08:52:07, Olivier Robin wrote:
> If an item is inserted (and index is not synchronized with iterator anymore),
> does it reload all items?

Yes. It is hard to find a good heuristic to calculate the diff.

https://codereview.chromium.org/2779893003/diff/1/ios/chrome/browser/ui/readi...
File ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
(right):

https://codereview.chromium.org/2779893003/diff/1/ios/chrome/browser/ui/readi...
ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h:58:
@property(nonatomic, readonly, strong) FaviconViewNew* faviconView;
On 2017/03/28 08:52:07, Olivier Robin wrote:
> Not for this CL, but why New?

I did not created this class, but I guess it is because there is a FaviconView
in history.

[gambard, 2017-03-29 07:57:43]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2017-03-29 07:57:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 08:09:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490774263284130, "parent_rev":
"fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b", "commit_rev":
"eee1c04986aabbf73c763b913c33d0d538f3ad5f"}

[commit-bot: I haz the power, 2017-03-29 08:10:42]

Description was changed from

==========
Removes the displayed cell in the ReadingList item

The Reading List item had a pointer to the cell displayed. This does not work
with auto layout.

BUG=705881
==========

to

==========
Removes the displayed cell in the ReadingList item

The Reading List item had a pointer to the cell displayed. This does not work
with auto layout.

BUG=705881

Review-Url: https://codereview.chromium.org/2779893003
Cr-Commit-Position: refs/heads/master@{#460324}
Committed:
https://chromium.googlesource.com/chromium/src/+/eee1c04986aabbf73c763b913c33...
==========

[commit-bot: I haz the power, 2017-03-29 08:10:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eee1c04986aabbf73c763b913c33...