Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2779793002: Update comments in WindowProxy to match current implementation. (Closed)

Created:
3 years, 8 months ago by dcheng
Modified:
3 years, 8 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update comments in WindowProxy to match current implementation. RemoteWindowProxy uses the v8 remote contexts now, so update the comments to reflect that. BUG=527190 Review-Url: https://codereview.chromium.org/2779793002 Cr-Commit-Position: refs/heads/master@{#460011} Committed: https://chromium.googlesource.com/chromium/src/+/1cfd7c66fd4befbd62f10526965413e682e84e13

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.h View 2 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dcheng
Merged the comments from https://codereview.chromium.org/2720973002/, which I forgot to update.
3 years, 8 months ago (2017-03-27 18:38:42 UTC) #3
haraken
LGTM
3 years, 8 months ago (2017-03-28 01:41:03 UTC) #7
Yuki
LGTM.
3 years, 8 months ago (2017-03-28 04:19:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779793002/1
3 years, 8 months ago (2017-03-28 04:19:58 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 04:24:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1cfd7c66fd4befbd62f105269654...

Powered by Google App Engine
This is Rietveld 408576698