Cherry-picked Display the preload Tab if it replaces the current Tab.

Cherry-picked Display the preload Tab if it replaces the current Tab.

BUG=698833, 702431, 705637
Original Review-Url: https://codereview.chromium.org/2759563003
TBR=kkhorimoto@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2779763006
Cr-Commit-Position: refs/branch-heads/3029@{#454}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/28c149b38283f61613fa2bea8da7e584df30a68c

[Eugene But (OOO till 7-30), 2017-03-28 17:12:01]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org, pkl@chromium.org

[Eugene But (OOO till 7-30), 2017-03-28 17:12:23]

Description was changed from

==========
Cherry-picked Display the preload Tab if it replaces the current Tab.

BUG=698833, 702431
Original Review-Url: https://codereview.chromium.org/2759563003
==========

to

==========
Cherry-picked Display the preload Tab if it replaces the current Tab.

BUG=698833, 702431, 705637
Original Review-Url: https://codereview.chromium.org/2759563003
TBR=kkhorimoto@chromium.org
==========

[kkhorimoto, 2017-03-28 17:16:58]

lgtm! Thanks for cherry-picking

[kkhorimoto, 2017-03-28 17:18:14]

https://codereview.chromium.org/2779763006/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2779763006/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:4482: // Add |newTab|'s view to
the hierarchy if it's the current Tab.
Do we need the uninstall/install delegate calls here still?

[Eugene But (OOO till 7-30), 2017-03-28 17:30:32]

Thanks for quick review!

https://codereview.chromium.org/2779763006/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2779763006/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:4482: // Add |newTab|'s view to
the hierarchy if it's the current Tab.
On 2017/03/28 17:18:14, kkhorimoto_ wrote:
> Do we need the uninstall/install delegate calls here still?
No, uninstalling/installing delegates methods do not exist on the branch.

[Eugene But (OOO till 7-30), 2017-03-28 17:30:36]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:31:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 17:31:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:31:13]

CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

[Eugene But (OOO till 7-30), 2017-03-28 17:47:39]

Description was changed from

==========
Cherry-picked Display the preload Tab if it replaces the current Tab.

BUG=698833, 702431, 705637
Original Review-Url: https://codereview.chromium.org/2759563003
TBR=kkhorimoto@chromium.org
==========

to

==========
Cherry-picked Display the preload Tab if it replaces the current Tab.

BUG=698833, 702431, 705637
Original Review-Url: https://codereview.chromium.org/2759563003
TBR=kkhorimoto@chromium.org
NOTRY=true
NOPRESUBMIT=true
==========

[Eugene But (OOO till 7-30), 2017-03-28 17:47:51]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:48:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 17:55:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490723271035600, "parent_rev":
"b8357dd7fdc55e484b98b4f9e792e439924b81eb", "commit_rev":
"28c149b38283f61613fa2bea8da7e584df30a68c"}

[commit-bot: I haz the power, 2017-03-28 17:56:19]

Description was changed from

==========
Cherry-picked Display the preload Tab if it replaces the current Tab.

BUG=698833, 702431, 705637
Original Review-Url: https://codereview.chromium.org/2759563003
TBR=kkhorimoto@chromium.org
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
Cherry-picked Display the preload Tab if it replaces the current Tab.

BUG=698833, 702431, 705637
Original Review-Url: https://codereview.chromium.org/2759563003
TBR=kkhorimoto@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2779763006
Cr-Commit-Position: refs/branch-heads/3029@{#454}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/28c149b38283f61613fa2bea8da7...
==========

[commit-bot: I haz the power, 2017-03-28 17:56:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28c149b38283f61613fa2bea8da7...