Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2779703002: DevTools: format generator objects as objects (Closed)

Created:
3 years, 9 months ago by luoe
Modified:
3 years, 9 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

DevTools: format generator objects as objects Objects of type 'generator' incorrectly went through the function formatter. Now they do go through the regular object formatter. BUG=704380 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2769973004 Cr-Commit-Position: refs/heads/master@{#459298} (cherry picked from commit 088e4a90947078a9dd6db43a21770ad14d0b9e43) Review-Url: https://codereview.chromium.org/2779703002 Cr-Commit-Position: refs/branch-heads/3029@{#443} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/541b24d277f0c1e514ddfc13a203af476c873219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6.html View 2 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt View 3 chunks +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
luoe
This is a merge to M58 (currently beta). Merge applied cleanly and requires a committer's ...
3 years, 9 months ago (2017-03-27 16:51:33 UTC) #2
lushnikov
lgtm
3 years, 9 months ago (2017-03-27 21:09:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779703002/1
3 years, 9 months ago (2017-03-27 21:14:07 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 9 months ago (2017-03-27 21:14:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779703002/1
3 years, 9 months ago (2017-03-27 21:53:43 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 22:07:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/541b24d277f0c1e514ddfc13a203...

Powered by Google App Engine
This is Rietveld 408576698