DevTools: format generator objects as objects

DevTools: format generator objects as objects

Objects of type 'generator' incorrectly went through the function formatter.
Now they do go through the regular object formatter.

BUG=704380
Review-Url: https://codereview.chromium.org/2769973004
Cr-Commit-Position: refs/heads/master@{#459298}
Committed: https://chromium.googlesource.com/chromium/src/+/088e4a90947078a9dd6db43a21770ad14d0b9e43

[luoe, 2017-03-23 17:16:10]

Description was changed from

==========
DevTools: format generator objects as objects

BUG=704380
==========

to

==========
DevTools: format generator objects as objects

Objects of type 'generator' incorrectly went through the function formatter.
Now they do go through the regular object formatter.

BUG=704380
==========

[luoe, 2017-03-23 17:16:34]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org, lushnikov@chromium.org

[luoe, 2017-03-23 17:16:34]

Please take a look

[lushnikov, 2017-03-23 20:48:18]

The code looks good! I didn't understand test changes though

https://codereview.chromium.org/2769973004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/console/console-format-es6.html
(right):

https://codereview.chromium.org/2769973004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/console/console-format-es6.html:64:
mapMap0, mapMap, setSet0, setSet, bigmap, p, generator
why do you add p one more time?

[luoe, 2017-03-23 20:55:56]

ptal

https://codereview.chromium.org/2769973004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/console/console-format-es6.html
(right):

https://codereview.chromium.org/2769973004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/console/console-format-es6.html:64:
mapMap0, mapMap, setSet0, setSet, bigmap, p, generator
On 2017/03/23 20:48:18, lushnikov wrote:
> why do you add p one more time?

Sorry, that's a typo!  I didn't see that it was already the first entry.  I've
made the order of globals match the order in which they are defined.

[luoe, 2017-03-23 20:56:04]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 20:56:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-03-23 20:57:07]

lgtm

[commit-bot: I haz the power, 2017-03-23 22:05:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:06:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[luoe, 2017-03-23 22:40:06]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-03-23 22:40:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2769973004/#ps60001
(title: "fix test result")

[commit-bot: I haz the power, 2017-03-23 22:40:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:26:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490308806421150,
"parent_rev": "2eefdd30dac56219587f39e35eac276444470401", "commit_rev":
"088e4a90947078a9dd6db43a21770ad14d0b9e43"}

[commit-bot: I haz the power, 2017-03-24 00:27:03]

Description was changed from

==========
DevTools: format generator objects as objects

Objects of type 'generator' incorrectly went through the function formatter.
Now they do go through the regular object formatter.

BUG=704380
==========

to

==========
DevTools: format generator objects as objects

Objects of type 'generator' incorrectly went through the function formatter.
Now they do go through the regular object formatter.

BUG=704380

Review-Url: https://codereview.chromium.org/2769973004
Cr-Commit-Position: refs/heads/master@{#459298}
Committed:
https://chromium.googlesource.com/chromium/src/+/088e4a90947078a9dd6db43a2177...
==========

[commit-bot: I haz the power, 2017-03-24 00:27:04]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/088e4a90947078a9dd6db43a2177...