Chromium Code Reviews Chromium Code Reviews
Issue
2779683002:
Revert of Add 'WithoutGeometryChange' variants of paint invalidation flag setters (Closed)
DescriptionRevert of Add 'WithoutGeometryChange' variants of paint invalidation flag setters (patchset #2 id:130001 of https://codereview.chromium.org/2751523011/ )
Reason for revert:
BUG=704182
Original issue's description:
> Reland of Add 'WithoutGeometryChange' variants of paint invalidation flag setters (patchset #1 id:1 of https://codereview.chromium.org/2752093005/ )
>
> Fix the issue by changing a setNeedsPaintOffsetAndVisualRectUpdate() call
> to setMayNeedPaintInvaldiation() call.
>
> Original issue's description:
> > Revert of Add 'WithoutGeometryChange' variants of paint invalidation flag setters (patchset #2 id:20001 of https://codereview.chromium.org/2751383003/ )
> >
> > Reason for revert:
> > Broke browser_tests: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/23685
> >
> > https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/23684
> >
> > Original issue's description:
> > > Add 'WithoutGeometryChange' variants of paint invalidation flag setters
> > >
> > > Add a flag needsPaintOffsetAndVisualRectUpdate() to indicate that the
> > > object needs paint offset and visual rect update during
> > > PrePaintTreeWalk.
> > >
> > > The original paint invalidation flag setters setMayNeedPaintInvalidation,
> > > setShouldDoFullPaintInvalidaiton and setters calling the two will set
> > > the new flag besides the original flags.
> > >
> > > Add 'WithoutGeometryChange' variants of the two setters to allow
> > > PrePaintTreeWalk to skip paint offset and visual rect update (to be
> > > implemented in later CLs).
> > >
> > > BUG=697081, 685179
> > >
> > > Review-Url: https://codereview.chromium.org/2751383003
> > > Cr-Commit-Position: refs/heads/master@{#457809}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/cabebfee33715afb9e577f6d133898b408390ab1
> >
> > TBR=pdr@chromium.org,wangxianzhu@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=697081, 685179
> >
> > Review-Url: https://codereview.chromium.org/2752093005
> > Cr-Commit-Position: refs/heads/master@{#457872}
> > Committed: https://chromium.googlesource.com/chromium/src/+/75c75092b256d5e3e0ae7ecafd1f8b3430246e1b
>
> TBR=pdr@chromium.org,dimich@chromium.org
> BUG=697081, 685179
>
> Review-Url: https://codereview.chromium.org/2751523011
> Cr-Commit-Position: refs/heads/master@{#457928}
> Committed: https://chromium.googlesource.com/chromium/src/+/5b49d1384ce8d1a8594bdb49f9f392da784b43bf
TBR=pdr@chromium.org,dimich@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697081, 685179
Patch Set 1 #
Messages
Total messages: 5 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
