Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2751383003: Add 'WithoutGeometryChange' variants of paint invalidation flag setters (Closed)

Created:
8 months, 1 week ago by Xianzhu
Modified:
8 months, 1 week ago
Reviewers:
pdr.
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 'WithoutGeometryChange' variants of paint invalidation flag setters Add a flag needsPaintOffsetAndVisualRectUpdate() to indicate that the object needs paint offset and visual rect update during PrePaintTreeWalk. The original paint invalidation flag setters setMayNeedPaintInvalidation, setShouldDoFullPaintInvalidaiton and setters calling the two will set the new flag besides the original flags. Add 'WithoutGeometryChange' variants of the two setters to allow PrePaintTreeWalk to skip paint offset and visual rect update (to be implemented in later CLs). BUG=697081, 685179 Review-Url: https://codereview.chromium.org/2751383003 Cr-Commit-Position: refs/heads/master@{#457809} Committed: https://chromium.googlesource.com/chromium/src/+/cabebfee33715afb9e577f6d133898b408390ab1

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -25 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 4 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 7 chunks +14 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 7 chunks +37 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp View 3 chunks +60 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Xianzhu
This is extracted from https://codereview.chromium.org/2732573003/ to reduce size.
8 months, 1 week ago (2017-03-17 00:58:59 UTC) #2
pdr.
On 2017/03/17 at 00:58:59, wangxianzhu wrote: > This is extracted from https://codereview.chromium.org/2732573003/ to reduce size. ...
8 months, 1 week ago (2017-03-17 02:08:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751383003/20001
8 months, 1 week ago (2017-03-17 02:22:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/410912)
8 months, 1 week ago (2017-03-17 05:18:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751383003/20001
8 months, 1 week ago (2017-03-17 15:55:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/cabebfee33715afb9e577f6d133898b408390ab1
8 months, 1 week ago (2017-03-17 17:44:21 UTC) #12
Dmitry Titov
8 months, 1 week ago (2017-03-17 20:14:52 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2752093005/ by dimich@chromium.org.

The reason for reverting is: Broke browser_tests:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C....

Powered by Google App Engine
This is Rietveld efc10ee0f