Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2779543007: Add DCHECK to WebEmbeddedWorkerImpl to assert WebFrameClient params. (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECK to WebEmbeddedWorkerImpl to assert WebFrameClient params. Since the WebLocalFrame* parameter being passed is already available from WebEmbeddedWorkerImpl, these should always match. This is pre-work to remove the (now redundant) parameter since it's already available from inside the method. BUG=361765 Review-Url: https://codereview.chromium.org/2779543007 Cr-Commit-Position: refs/heads/master@{#460302} Committed: https://chromium.googlesource.com/chromium/src/+/0611b01da7b4979fada8de6369f948cc3ba53dd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
sashab
3 years, 8 months ago (2017-03-28 23:22:04 UTC) #3
joelhockey
lgtm
3 years, 8 months ago (2017-03-29 00:28:14 UTC) #6
sashab
3 years, 8 months ago (2017-03-29 00:28:53 UTC) #8
sashab
-haraken +dcheng
3 years, 8 months ago (2017-03-29 03:27:29 UTC) #12
dcheng
rs lgtm
3 years, 8 months ago (2017-03-29 03:58:47 UTC) #13
kinuko
lgtm (and ditto)
3 years, 8 months ago (2017-03-29 04:52:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779543007/1
3 years, 8 months ago (2017-03-29 05:04:19 UTC) #16
haraken
LGTM
3 years, 8 months ago (2017-03-29 06:20:09 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 06:36:11 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0611b01da7b4979fada8de6369f9...

Powered by Google App Engine
This is Rietveld 408576698