|
|
Chromium Code Reviews
DescriptionAdd DCHECK to WebEmbeddedWorkerImpl to assert WebFrameClient params.
Since the WebLocalFrame* parameter being passed is already available
from WebEmbeddedWorkerImpl, these should always match. This is pre-work
to remove the (now redundant) parameter since it's already available
from inside the method.
BUG=361765
Review-Url: https://codereview.chromium.org/2779543007
Cr-Commit-Position: refs/heads/master@{#460302}
Committed: https://chromium.googlesource.com/chromium/src/+/0611b01da7b4979fada8de6369f948cc3ba53dd2
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
sashab@chromium.org changed reviewers: + joelhockey@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add DCHECKs to WebEmbeddedWorkerImpl to assert WebFrameClient params. Since the WebLocalFrame* parameter being passed is already available from WebEmbeddedWorkerImpl, these should always match. This is pre-work to remove the (now redundant) parameter since it's already available from inside the method. BUG=361765 ========== to ========== Add DCHECK to WebEmbeddedWorkerImpl to assert WebFrameClient params. Since the WebLocalFrame* parameter being passed is already available from WebEmbeddedWorkerImpl, these should always match. This is pre-work to remove the (now redundant) parameter since it's already available from inside the method. BUG=361765 ==========
lgtm
sashab@chromium.org changed reviewers: + haraken@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
sashab@chromium.org changed reviewers: + dcheng@chromium.org - haraken@chromium.org
-haraken +dcheng
rs lgtm
lgtm (and ditto)
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490763833673630, "parent_rev":
"f244469aa781823cdde22de772e1ca1944f55b2f", "commit_rev":
"0611b01da7b4979fada8de6369f948cc3ba53dd2"}
Message was sent while issue was closed.
Description was changed from ========== Add DCHECK to WebEmbeddedWorkerImpl to assert WebFrameClient params. Since the WebLocalFrame* parameter being passed is already available from WebEmbeddedWorkerImpl, these should always match. This is pre-work to remove the (now redundant) parameter since it's already available from inside the method. BUG=361765 ========== to ========== Add DCHECK to WebEmbeddedWorkerImpl to assert WebFrameClient params. Since the WebLocalFrame* parameter being passed is already available from WebEmbeddedWorkerImpl, these should always match. This is pre-work to remove the (now redundant) parameter since it's already available from inside the method. BUG=361765 Review-Url: https://codereview.chromium.org/2779543007 Cr-Commit-Position: refs/heads/master@{#460302} Committed: https://chromium.googlesource.com/chromium/src/+/0611b01da7b4979fada8de6369f9... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0611b01da7b4979fada8de6369f9... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
