Use ScreenOrientationController and not the implementation to break modules/ dep.

Use ScreenOrientationController and not the implementation to break modules/ dep.

WebLocalFrameImpl was using ScreenOrientationControllerImpl as the method
notifyOrientationChanged was not defined in ScreenOrientationController. By
making this method pure virtual in ScreenOrientationController we no longer
need to pull in ScreenOrientationControllerImpl from modules but can now use the
base class defined in core/frame/.

BUG=703405
Review-Url: https://codereview.chromium.org/2779523002
Cr-Commit-Position: refs/heads/master@{#459935}
Committed: https://chromium.googlesource.com/chromium/src/+/96d533dcfc175886ce842d1fc5c4e0ea7f26e0a6

[slangley, 2017-03-27 03:48:36]

slangley@chromium.org changed reviewers:
+ joelhockey@chromium.org

[joelhockey, 2017-03-27 03:49:57]

lgtm

[slangley, 2017-03-27 03:51:51]

dcheng@ - ptal

[haraken, 2017-03-27 04:00:35]

LGTM

[slangley, 2017-03-27 04:03:03]

slangley@chromium.org changed reviewers:
+ haraken@chromium.org

[slangley, 2017-03-27 04:03:09]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-03-27 04:03:17]

The CQ bit was unchecked by slangley@chromium.org

[slangley, 2017-03-27 04:03:35]

Description was changed from

==========
Use ScreenOrientationController and not the implementatin to break modules/ dep.

WebLocalFrameImpl was using ScreenOrientationControllerImpl as the method
notifyOrientationChanged was not defined in ScreenOrientationController. By
making this method pure virtual in ScreenOrientationController we no longer
need to pull in ScreenOrientationControllerImpl from modules but can now use the
base class defined in core/frame/.

BUG=703405
==========

to

==========
Use ScreenOrientationController and not the implementation to break modules/
dep.

WebLocalFrameImpl was using ScreenOrientationControllerImpl as the method
notifyOrientationChanged was not defined in ScreenOrientationController. By
making this method pure virtual in ScreenOrientationController we no longer
need to pull in ScreenOrientationControllerImpl from modules but can now use the
base class defined in core/frame/.

BUG=703405
==========

[slangley, 2017-03-27 04:03:41]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-03-27 04:03:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 05:16:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 05:16:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mlamouri (slow - plz ping), 2017-03-27 08:26:32]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-03-27 08:26:32]

lgtm

[slangley, 2017-03-27 22:56:10]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-03-27 22:57:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 23:35:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490655370723990, "parent_rev":
"14e3acc30f4da1fe3f601828101af47eff68a828", "commit_rev":
"96d533dcfc175886ce842d1fc5c4e0ea7f26e0a6"}

[commit-bot: I haz the power, 2017-03-27 23:37:30]

Description was changed from

==========
Use ScreenOrientationController and not the implementation to break modules/
dep.

WebLocalFrameImpl was using ScreenOrientationControllerImpl as the method
notifyOrientationChanged was not defined in ScreenOrientationController. By
making this method pure virtual in ScreenOrientationController we no longer
need to pull in ScreenOrientationControllerImpl from modules but can now use the
base class defined in core/frame/.

BUG=703405
==========

to

==========
Use ScreenOrientationController and not the implementation to break modules/
dep.

WebLocalFrameImpl was using ScreenOrientationControllerImpl as the method
notifyOrientationChanged was not defined in ScreenOrientationController. By
making this method pure virtual in ScreenOrientationController we no longer
need to pull in ScreenOrientationControllerImpl from modules but can now use the
base class defined in core/frame/.

BUG=703405

Review-Url: https://codereview.chromium.org/2779523002
Cr-Commit-Position: refs/heads/master@{#459935}
Committed:
https://chromium.googlesource.com/chromium/src/+/96d533dcfc175886ce842d1fc5c4...
==========

[commit-bot: I haz the power, 2017-03-27 23:37:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96d533dcfc175886ce842d1fc5c4...