third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h - Issue 2779523002: Use ScreenOrientationController and not the implementation to break modules/ dep.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

Issue 2779523002: Use ScreenOrientationController and not the implementation to break modules/ dep. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

index dadb7f5da61ef47c061c04d9de658e219791cdec..c87e6810fddb332825dd4bf78f1252b02f3e543d 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

@@ -30,7 +30,7 @@ class MODULES_EXPORT ScreenOrientationControllerImpl final

~ScreenOrientationControllerImpl() override;

void setOrientation(ScreenOrientation*);

- void notifyOrientationChanged();

+ void notifyOrientationChanged() override;

// Implementation of ScreenOrientationController.

void lock(WebScreenOrientationLockType,