Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Issue 2779483002: Revert of [Chromoting] Send DesktopFrame::capturer_id() to client through WebrtcVideoStream (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
Sergey Ulanov, Hzj_jie
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org, Jamie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromoting] Send DesktopFrame::capturer_id() to client through WebrtcVideoStream (patchset #2 id:40001 of https://codereview.chromium.org/2767193007/ ) Reason for revert: Speculative, looks like this broke Webrtc_ConnectionTest.SecondCaptureFailed_0 on msan: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/6646 Original issue's description: > [Chromoting] Send DesktopFrame::capturer_id() to client through WebrtcVideoStream > > Once DirectX Capturer is enabled or being experimented, we can use the > capturer_id() logged in clients to analyze the failure rate. > > BUG=650926, 679523 > > Review-Url: https://codereview.chromium.org/2767193007 > Cr-Commit-Position: refs/heads/master@{#459625} > Committed: https://chromium.googlesource.com/chromium/src/+/f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db TBR=sergeyu@chromium.org,zijiehe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=650926, 679523 Review-Url: https://codereview.chromium.org/2779483002 Cr-Commit-Position: refs/heads/master@{#459665} Committed: https://chromium.googlesource.com/chromium/src/+/d019ead71fc0056f622b6955e4ea599d43231e32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -51 lines) Patch
M remoting/proto/video_stats.proto View 2 chunks +0 lines, -5 lines 0 comments Download
M remoting/protocol/frame_stats.h View 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/protocol/frame_stats.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/protocol/webrtc_video_stream.h View 3 chunks +7 lines, -7 lines 0 comments Download
M remoting/protocol/webrtc_video_stream.cc View 7 chunks +29 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
Created Revert of [Chromoting] Send DesktopFrame::capturer_id() to client through WebrtcVideoStream
3 years, 9 months ago (2017-03-26 01:32:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779483002/1
3 years, 9 months ago (2017-03-26 01:32:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d019ead71fc0056f622b6955e4ea599d43231e32
3 years, 9 months ago (2017-03-26 01:34:37 UTC) #6
Nico
This helped, remoting_unittests on tsan no longer fails with this in: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/6668
3 years, 9 months ago (2017-03-26 03:21:56 UTC) #7
Nico
3 years, 9 months ago (2017-03-26 03:22:05 UTC) #8
Message was sent while issue was closed.
On 2017/03/26 03:21:56, Nico wrote:
> This helped, remoting_unittests on tsan no longer fails with this in:
>
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...

err, s/tsan/msan/

Powered by Google App Engine
This is Rietveld 408576698