Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 2767193007: [Chromoting] Send DesktopFrame::capturer_id() to client through WebrtcVideoStream (Closed)

Created:
3 years, 9 months ago by Hzj_jie
Modified:
3 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org, Jamie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Send DesktopFrame::capturer_id() to client through WebrtcVideoStream Once DirectX Capturer is enabled or being experimented, we can use the capturer_id() logged in clients to analyze the failure rate. BUG=650926, 679523 Review-Url: https://codereview.chromium.org/2767193007 Cr-Original-Commit-Position: refs/heads/master@{#459625} Committed: https://chromium.googlesource.com/chromium/src/+/f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db Review-Url: https://codereview.chromium.org/2767193007 Cr-Commit-Position: refs/heads/master@{#459684} Committed: https://chromium.googlesource.com/chromium/src/+/805f2ca5aa0902f56885ea3c8c0a42cb80d84522

Patch Set 1 #

Total comments: 2

Patch Set 2 : Resolve review comments #

Patch Set 3 : crash in msan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -36 lines) Patch
M remoting/proto/video_stats.proto View 2 chunks +5 lines, -0 lines 0 comments Download
M remoting/protocol/frame_stats.h View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/protocol/frame_stats.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/protocol/webrtc_video_stream.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M remoting/protocol/webrtc_video_stream.cc View 1 2 7 chunks +36 lines, -29 lines 0 comments Download

Messages

Total messages: 33 (25 generated)
Hzj_jie
3 years, 9 months ago (2017-03-23 23:59:48 UTC) #7
Sergey Ulanov
LGTM after my comment is addressed. https://codereview.chromium.org/2767193007/diff/20001/remoting/protocol/webrtc_video_stream.cc File remoting/protocol/webrtc_video_stream.cc (right): https://codereview.chromium.org/2767193007/diff/20001/remoting/protocol/webrtc_video_stream.cc#newcode44 remoting/protocol/webrtc_video_stream.cc:44: uint32_t capturer_id; I ...
3 years, 9 months ago (2017-03-24 23:54:26 UTC) #8
Hzj_jie
https://codereview.chromium.org/2767193007/diff/20001/remoting/protocol/webrtc_video_stream.cc File remoting/protocol/webrtc_video_stream.cc (right): https://codereview.chromium.org/2767193007/diff/20001/remoting/protocol/webrtc_video_stream.cc#newcode44 remoting/protocol/webrtc_video_stream.cc:44: uint32_t capturer_id; On 2017/03/24 23:54:26, Sergey Ulanov wrote: > ...
3 years, 9 months ago (2017-03-25 02:15:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767193007/40001
3 years, 9 months ago (2017-03-25 02:20:04 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db
3 years, 9 months ago (2017-03-25 02:24:43 UTC) #19
Nico
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/2779483002/ by thakis@chromium.org. ...
3 years, 9 months ago (2017-03-26 01:32:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767193007/60001
3 years, 9 months ago (2017-03-27 00:52:23 UTC) #30
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 00:57:48 UTC) #33
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/805f2ca5aa0902f56885ea3c8c0a...

Powered by Google App Engine
This is Rietveld 408576698